Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary write lock in block_verification #4334

Closed
michaelsproul opened this issue May 26, 2023 · 1 comment
Closed

Unnecessary write lock in block_verification #4334

michaelsproul opened this issue May 26, 2023 · 1 comment
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! optimization Something to make Lighthouse run more efficiently. v4.3.0 Estimated Q2 2023

Comments

@michaelsproul
Copy link
Member

Description

This could be a read:

lighthouse/beacon_node/beacon_chain/src/block_verification.rs

Lines 748 to 752 in c547a11

check_block_is_finalized_checkpoint_or_descendant(
chain,
&chain.canonical_head.fork_choice_write_lock(),
&block,
)?;

@michaelsproul michaelsproul added low-hanging-fruit Easy to resolve, get it before someone else does! optimization Something to make Lighthouse run more efficiently. v4.3.0 Estimated Q2 2023 labels May 26, 2023
@eserilev eserilev mentioned this issue May 26, 2023
Closed
@eserilev
Copy link
Collaborator

since its such a small change, I went ahead and opened a PR

bors bot pushed a commit that referenced this issue May 30, 2023
@eserilev @michaelsproul
swap unnecessary write lock to read lock in block_verification (#4340)
db99490 
## Issue Addressed

[#4334](#4334)

## Proposed Changes

swap unnecessary write lock to read lock

## Additional Info

N/A


Co-authored-by: Michael Sproul <micsproul@gmail.com>
bors bot pushed a commit that referenced this issue May 30, 2023
@eserilev @michaelsproul
swap unnecessary write lock to read lock in block_verification (#4340)
2a7e54d 
## Issue Addressed

[#4334](#4334)

## Proposed Changes

swap unnecessary write lock to read lock

## Additional Info

N/A


Co-authored-by: Michael Sproul <micsproul@gmail.com>
divagant-martian pushed a commit to divagant-martian/lighthouse that referenced this issue Jun 7, 2023
@eserilev @michaelsproul @divagant-martian
swap unnecessary write lock to read lock in block_verification (sigp#…
402386d 
…4340)

## Issue Addressed

[sigp#4334](sigp#4334)

## Proposed Changes

swap unnecessary write lock to read lock

## Additional Info

N/A


Co-authored-by: Michael Sproul <micsproul@gmail.com>
ghost pushed a commit to oone-world/lighthouse that referenced this issue Jul 13, 2023
@eserilev @michaelsproul
swap unnecessary write lock to read lock in block_verification (sigp#…
8f42657 
…4340)

## Issue Addressed

[sigp#4334](sigp#4334)

## Proposed Changes

swap unnecessary write lock to read lock

## Additional Info

N/A


Co-authored-by: Michael Sproul <micsproul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! optimization Something to make Lighthouse run more efficiently. v4.3.0 Estimated Q2 2023
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @eserilev