Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - swap unnecessary write lock to read lock in block_verification #4340

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - swap unnecessary write lock to read lock in block_verification #4340

wants to merge 3 commits into from

Conversation

eserilev
Copy link
Collaborator

Issue Addressed

#4334

Proposed Changes

swap unnecessary write lock to read lock

Additional Info

N/A

@eserilev eserilev changed the title swap write lock to read lock swap unnecessary write lock to read lock in block_verification May 26, 2023
@eserilev eserilev changed the base branch from stable to unstable May 26, 2023 14:51
michaelsproul
michaelsproul approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label May 30, 2023
@michaelsproul
Copy link
Member

Pushed some no-op commits to fix the CI branch check

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 30, 2023
@eserilev @michaelsproul
swap unnecessary write lock to read lock in block_verification (#4340)
db99490 
## Issue Addressed

[#4334](#4334)

## Proposed Changes

swap unnecessary write lock to read lock

## Additional Info

N/A


Co-authored-by: Michael Sproul <micsproul@gmail.com>
@bors
Copy link

bors bot commented May 30, 2023

Build failed (retrying...):

@michaelsproul
Copy link
Member

bors r-

@bors
Copy link

bors bot commented May 30, 2023

Canceled.

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 30, 2023
@eserilev @michaelsproul
swap unnecessary write lock to read lock in block_verification (#4340)
2a7e54d 
## Issue Addressed

[#4334](#4334)

## Proposed Changes

swap unnecessary write lock to read lock

## Additional Info

N/A


Co-authored-by: Michael Sproul <micsproul@gmail.com>
@bors
Copy link

bors bot commented May 30, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title swap unnecessary write lock to read lock in block_verification [Merged by Bors] - swap unnecessary write lock to read lock in block_verification May 30, 2023
@bors bors bot closed this May 30, 2023
divagant-martian pushed a commit to divagant-martian/lighthouse that referenced this pull request Jun 7, 2023
@eserilev @michaelsproul @divagant-martian
swap unnecessary write lock to read lock in block_verification (sigp#…
402386d 
…4340)

## Issue Addressed

[sigp#4334](sigp#4334)

## Proposed Changes

swap unnecessary write lock to read lock

## Additional Info

N/A


Co-authored-by: Michael Sproul <micsproul@gmail.com>
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
@eserilev @michaelsproul
swap unnecessary write lock to read lock in block_verification (sigp#…
8f42657 
…4340)

## Issue Addressed

[sigp#4334](sigp#4334)

## Proposed Changes

swap unnecessary write lock to read lock

## Additional Info

N/A


Co-authored-by: Michael Sproul <micsproul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eserilev @michaelsproul