Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - swap unnecessary write lock to read lock in block_verification #4340

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - swap unnecessary write lock to read lock in block_verification #4340

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d5b12c
swap write lock to read lock
eserilev May 26, 2023
2b74453
Update beacon_node/beacon_chain/src/block_verification.rs
michaelsproul May 30, 2023
2e1802c
Update beacon_node/beacon_chain/src/block_verification.rs
michaelsproul May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beacon_node/beacon_chain/src/block_verification.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ impl<T: BeaconChainTypes> GossipVerifiedBlock<T> {
// We check this *before* we load the parent so that we can return a more detailed error.
check_block_is_finalized_checkpoint_or_descendant(
chain,
&chain.canonical_head.fork_choice_write_lock(),
&chain.canonical_head.fork_choice_read_lock(),
michaelsproul marked this conversation as resolved.
Show resolved Hide resolved
&block,
)?;

Expand Down