Proposer and attester slashing sse events #5327

eserilev · 2024-02-28T14:16:08Z

Issue Addressed

#5011

Proposed Changes

Add proposer and attester slashing sse events

spec: ethereum/beacon-APIs#376

…stable

…oposer-and-attester-slashing-sse-events

eserilev · 2024-02-28T14:17:20Z

beacon_node/http_api/tests/tests.rs

+        )
+        .await;
+
+        assert!(attester_slashing_event.len() > 0);


we probably want to assert for more than just asset_slashing_event.len() > 0?

beacon_node/http_api/tests/tests.rs

beacon_node/beacon_chain/src/beacon_chain.rs

dapplion

Looks good to me!

beacon_node/beacon_chain/src/test_utils.rs

common/eth2/src/types.rs

…ithub.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events

eserilev · 2024-04-03T21:31:12Z

thanks for the reviews. I pushed up the requested changes

…oposer-and-attester-slashing-sse-events

michaelsproul · 2024-04-30T07:08:56Z

@Mergifyio queue

mergify · 2024-04-30T07:09:07Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d3bf9a8

Squashed commit of the following: commit ea8373b Merge: cf72485 c33edc8 Author: realbigsean <seananderson33@GMAIL.com> Date: Mon Apr 29 17:33:23 2024 -0400 Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events commit cf72485 Merge: e1a6414 feb531f Author: realbigsean <seananderson33@GMAIL.com> Date: Thu Apr 4 11:48:00 2024 -0400 Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events commit e1a6414 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Thu Apr 4 00:29:50 2024 +0300 leftover debugging commit ec2eacc Merge: be5fa49 d6ab56e Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Thu Apr 4 00:28:26 2024 +0300 Merge branch 'proposer-and-attester-slashing-sse-events' of https://github.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events commit be5fa49 Merge: e2fdbc3 969d12d Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Thu Apr 4 00:27:15 2024 +0300 resolve merge conflicts commit e2fdbc3 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Wed Apr 3 23:52:46 2024 +0300 remove todo, fix test commit d6ab56e Merge: a3e42d3 969d12d Author: Lion - dapplion <35266934+dapplion@users.noreply.github.com> Date: Wed Apr 3 11:07:19 2024 +0900 Merge branch 'unstable' into proposer-and-attester-slashing-sse-events commit a3e42d3 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue Mar 12 17:10:47 2024 +0200 remove double event tracking commit 504635d Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Wed Feb 28 16:09:25 2024 +0200 revert commit d0f0f82 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Wed Feb 28 16:07:29 2024 +0200 revert commit b4b734d Merge: c1bacad 64e563f Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Wed Feb 28 15:57:43 2024 +0200 Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events commit c1bacad Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Wed Feb 28 15:55:35 2024 +0200 add tests, event triggers commit da00e0e Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue Feb 27 18:36:43 2024 +0200 add TOOOs commit 0273c05 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue Feb 27 18:31:28 2024 +0200 add proposer and attester event variants commit 7c13a8f Merge: 3ea8476 abd9965 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue Feb 27 18:10:22 2024 +0200 Merge branch 'unstable' of https://github.com/sigp/lighthouse into unstable commit 3ea8476 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Sun Feb 25 14:53:04 2024 +0200 default vc to block v3 endpoint and deprecate block-v3 flag

* Fix execution integration tests (#5647) * update waiting status * revert to old nethermind version * Add electra presets to beacon API (#5630) * add presets to API * add extra fields to config spec in beacon API * remove unused * add mainnet presets for gnosis and fix minimal preset default values * Rename `Merge` to `Bellatrix` (#5601) * Rename Merge to Bellatrix * Remove tree-hash-cache which got readded from the rebase * Deterministic block generation for tests (#5654) * Deterministic block generation for tests * Electra other containers (#5652) * add new fields to execution payload and header * beacon state changes * partial beacon state * safe arith in upgrade to electra * initialize balances cache in interop genesis state * Revert "initialize balances cache in interop genesis state" This reverts commit c60b522. * always initialize balances cache if necessary in electra upgrade * build cache earlier * fix block test * per fork NUM_FIELDS_POW2 * Merge branch 'unstable' of https://github.com/sigp/lighthouse into electra-other-containers * fix lints * get fields based on post state, as is spec'd * fix type and move cache build * Add more electra helpers (#5653) * Add new helpers * Fix some stuff * Fix compilation errors * lint * Address review * Ignore gossip blob already imported (#5656) * Ignore gossip blob already imported * Beta compiler fix (#5659) * fix beta compiler compilation * remove unused import * Revert "remove unused import" This reverts commit 0bef36b. * Revert "fix beta compiler compilation" This reverts commit 23152cf. * rename ununsed fields * allow dead code on some error variants * remove unused blob download queue * add back debug to backfill error * more allow dead code on errors * fix(validator_client): raise soft fd limit (#4796) * fix(validator_client): raise soft fd limit * Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit * cargo lock * Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit * Proposer and attester slashing sse events (#5327) * default vc to block v3 endpoint and deprecate block-v3 flag * Merge branch 'unstable' of https://github.com/sigp/lighthouse into unstable * add proposer and attester event variants * add TOOOs * add tests, event triggers * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * revert * revert * remove double event tracking * Merge branch 'unstable' into proposer-and-attester-slashing-sse-events * remove todo, fix test * resolve merge conflicts * Merge branch 'proposer-and-attester-slashing-sse-events' of https://github.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events * leftover debugging * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * pin macos release runner to `macos-13` (#5665) * pin macos release runner to `macos-13` * Update .github/workflows/release.yml * Remove snapshot cache related code (#5661) * Remove snapshot cache and other references. * Fix default state cache size in docs * Remove cache miss comment entirely * Add state cache CLI tests * Uncomment self_hosted_runner after PR Merge #5137 (#5291) * Uncomment self_hosted_runner after PR Merge #5137 * Merge branch 'unstable' into fix_todo * Merge branch 'unstable' of https://github.com/sigp/lighthouse into fix_todo * Only `portable` builds (binaries) (#5615) * release workflow: portable builds by default * Delete outdated comment * Merge branch 'unstable' into portable-builds-binaries # Conflicts: # .github/workflows/release.yml * Merge parent and current sync lookups (#5655) * Drop lookup type trait for a simple arg * Drop reconstructed for processing * Send parent blocks one by one * Merge current and parent lookups * Merge current and parent lookups clean up todos * Merge current and parent lookups tests * Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup * Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup * fix compile after merge * #5655 pr review (#26) * fix compile after merge * remove todos, fix typos etc * fix compile * stable rng * delete TODO and unfilled out test * make download result a struct * enums instead of bools as params * fix comment * Various fixes * Track ignored child components * Track dropped lookup reason as metric * fix test * add comment describing behavior of avail check error * update ordering * delete spammy log (#5672) * delete spammy log * Ensure block only range requests don't fail on download (#5675) * ensure pruned blobs don't fail on download * Typo * Improve ENR updates (#5483) * Improve ENR updates * forever fmt * Appease my old friend clippy * Merge network unstable * Check da_checker before doing a block lookup request (#5681) * Check da_checker before doing a block lookup request * Ensure consistent handling of lookup result * use req resp pre import cache rather than da checker * Update Cargo.lock (#5670) * update rust-yamux * update Cargo.lock * Merge branch 'unstable' of github.com:jxs/lighthouse into update-cargo * Merge branch 'unstable' of github.com:sigp/lighthouse into update-cargo * update to new libp2p versions * Add metric for current epoch total balance (#5688) * Add metric for current epoch total balance --------- Co-authored-by: realbigsean <sean@sigmaprime.io> Co-authored-by: Mac L <mjladson@pm.me> Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com> Co-authored-by: Pawan Dhananjay <pawandhananjay@gmail.com> Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com> Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu> Co-authored-by: antondlr <anton@delaruelle.net> Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> Co-authored-by: Ærvin <arvin.morawej@gmail.com> Co-authored-by: Age Manning <Age@AgeManning.com> Co-authored-by: João Oliveira <hello@jxs.pt> Co-authored-by: Michael Sproul <michael@sigmaprime.io>

* default vc to block v3 endpoint and deprecate block-v3 flag * Merge branch 'unstable' of https://github.com/sigp/lighthouse into unstable * add proposer and attester event variants * add TOOOs * add tests, event triggers * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * revert * revert * remove double event tracking * Merge branch 'unstable' into proposer-and-attester-slashing-sse-events * remove todo, fix test * resolve merge conflicts * Merge branch 'proposer-and-attester-slashing-sse-events' of https://github.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events * leftover debugging * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events

eserilev added 8 commits February 25, 2024 14:53

default vc to block v3 endpoint and deprecate block-v3 flag

3ea8476

Merge branch 'unstable' of https://github.com/sigp/lighthouse into un…

7c13a8f

…stable

add proposer and attester event variants

0273c05

add TOOOs

da00e0e

add tests, event triggers

c1bacad

Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…

b4b734d

…oposer-and-attester-slashing-sse-events

revert

d0f0f82

revert

504635d

eserilev commented Feb 28, 2024

View reviewed changes

beacon_node/http_api/tests/tests.rs Show resolved Hide resolved

eserilev commented Feb 28, 2024

View reviewed changes

beacon_node/http_api/tests/tests.rs Show resolved Hide resolved

jimmygchen added ready-for-review The code is ready for review HTTP-API labels Mar 1, 2024

macladson reviewed Mar 4, 2024

View reviewed changes

beacon_node/beacon_chain/src/beacon_chain.rs Outdated Show resolved Hide resolved

eserilev added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Mar 7, 2024

remove double event tracking

a3e42d3

eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Mar 13, 2024

dapplion approved these changes Mar 18, 2024

View reviewed changes

eserilev added the v5.2.0 Q2 2024 label Mar 31, 2024

Merge branch 'unstable' into proposer-and-attester-slashing-sse-events

d6ab56e

dapplion requested a review from macladson April 3, 2024 02:07

macladson requested changes Apr 3, 2024

View reviewed changes

beacon_node/beacon_chain/src/test_utils.rs Outdated Show resolved Hide resolved

common/eth2/src/types.rs Outdated Show resolved Hide resolved

macladson requested changes Apr 3, 2024

View reviewed changes

common/eth2/src/types.rs Outdated Show resolved Hide resolved

eserilev added 4 commits April 3, 2024 23:52

remove todo, fix test

e2fdbc3

resolve merge conflicts

be5fa49

Merge branch 'proposer-and-attester-slashing-sse-events' of https://g…

ec2eacc

…ithub.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events

leftover debugging

e1a6414

realbigsean added 2 commits April 4, 2024 11:48

Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…

cf72485

…oposer-and-attester-slashing-sse-events

Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…

ea8373b

…oposer-and-attester-slashing-sse-events

michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 30, 2024

michaelsproul mentioned this pull request Apr 30, 2024

Release v5.2.0 #5664

Merged

mergify bot added a commit that referenced this pull request Apr 30, 2024

Merge of #5327

36e6af8

This was referenced Apr 30, 2024

merge queue: embarking unstable (c8ffafb) and [#5327 + #5665] together #5666

Closed

pin macos release runner to macos-13 #5665

Merged

mergify bot merged commit d3bf9a8 into sigp:unstable Apr 30, 2024
27 checks passed

jimmygchen mentioned this pull request May 1, 2024

Proposer and attester slashing events #5011

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proposer and attester slashing sse events #5327

Proposer and attester slashing sse events #5327

eserilev commented Feb 28, 2024

eserilev Feb 28, 2024

dapplion left a comment

eserilev commented Apr 3, 2024 •

edited

Loading

michaelsproul commented Apr 30, 2024

mergify bot commented Apr 30, 2024 •

edited

Loading

Proposer and attester slashing sse events #5327

Proposer and attester slashing sse events #5327

Conversation

eserilev commented Feb 28, 2024

Issue Addressed

Proposed Changes

eserilev Feb 28, 2024

Choose a reason for hiding this comment

dapplion left a comment

Choose a reason for hiding this comment

eserilev commented Apr 3, 2024 • edited Loading

michaelsproul commented Apr 30, 2024

mergify bot commented Apr 30, 2024 • edited Loading

✅ The pull request has been merged automatically

eserilev commented Apr 3, 2024 •

edited

Loading

mergify bot commented Apr 30, 2024 •

edited

Loading