Only `portable` builds (binaries) #5615

antondlr · 2024-04-22T08:48:43Z

See #5489 for details, this is a cleaner version of the release/binaries part of that PR

For backwards compatibility, we still publish a copy of the binaries with the portablename. This is meant to be phased out as we direct our users towards the regular (now, portable) release.

michaelsproul · 2024-04-28T23:17:07Z

.github/workflows/release.yml

@@ -166,6 +131,7 @@ jobs:
                  tar -czf lighthouse-${{ needs.extract-version.outputs.VERSION }}-${{ matrix.arch }}.tar.gz lighthouse.exe
                  gpg --passphrase "$env:GPG_PASSPHRASE" --batch --pinentry-mode loopback -ab lighthouse-${{ needs.extract-version.outputs.VERSION }}-${{ matrix.arch }}.tar.gz
                  move *tar.gz* ..
+                  # todo copy to `-portable`


I think this comment can be deleted (already done above)

michaelsproul

approved modulo removing that comment

.github/workflows/release.yml

michaelsproul · 2024-04-30T06:51:08Z

@Mergifyio queue

mergify · 2024-04-30T06:51:24Z

queue

🛑 The pull request has been removed from the queue `default`

The pull request #5615 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Squashed commit of the following: commit 4f539f2 Author: Michael Sproul <micsproul@gmail.com> Date: Tue Apr 30 16:50:47 2024 +1000 Delete outdated comment commit 67a88a2 Author: antondlr <anton@delaruelle.net> Date: Mon Apr 22 10:44:31 2024 +0200 release workflow: portable builds by default

# Conflicts: # .github/workflows/release.yml

realbigsean · 2024-04-30T15:56:30Z

@mergify queue

mergify · 2024-04-30T15:56:50Z

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

realbigsean · 2024-04-30T19:00:00Z

@mergify queue

mergify · 2024-04-30T19:00:17Z

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

realbigsean · 2024-04-30T19:12:06Z

@mergify requeue

mergify · 2024-04-30T19:12:19Z

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-04-30T19:12:21Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 196d9fd

* Fix execution integration tests (#5647) * update waiting status * revert to old nethermind version * Add electra presets to beacon API (#5630) * add presets to API * add extra fields to config spec in beacon API * remove unused * add mainnet presets for gnosis and fix minimal preset default values * Rename `Merge` to `Bellatrix` (#5601) * Rename Merge to Bellatrix * Remove tree-hash-cache which got readded from the rebase * Deterministic block generation for tests (#5654) * Deterministic block generation for tests * Electra other containers (#5652) * add new fields to execution payload and header * beacon state changes * partial beacon state * safe arith in upgrade to electra * initialize balances cache in interop genesis state * Revert "initialize balances cache in interop genesis state" This reverts commit c60b522. * always initialize balances cache if necessary in electra upgrade * build cache earlier * fix block test * per fork NUM_FIELDS_POW2 * Merge branch 'unstable' of https://github.com/sigp/lighthouse into electra-other-containers * fix lints * get fields based on post state, as is spec'd * fix type and move cache build * Add more electra helpers (#5653) * Add new helpers * Fix some stuff * Fix compilation errors * lint * Address review * Ignore gossip blob already imported (#5656) * Ignore gossip blob already imported * Beta compiler fix (#5659) * fix beta compiler compilation * remove unused import * Revert "remove unused import" This reverts commit 0bef36b. * Revert "fix beta compiler compilation" This reverts commit 23152cf. * rename ununsed fields * allow dead code on some error variants * remove unused blob download queue * add back debug to backfill error * more allow dead code on errors * fix(validator_client): raise soft fd limit (#4796) * fix(validator_client): raise soft fd limit * Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit * cargo lock * Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit * Proposer and attester slashing sse events (#5327) * default vc to block v3 endpoint and deprecate block-v3 flag * Merge branch 'unstable' of https://github.com/sigp/lighthouse into unstable * add proposer and attester event variants * add TOOOs * add tests, event triggers * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * revert * revert * remove double event tracking * Merge branch 'unstable' into proposer-and-attester-slashing-sse-events * remove todo, fix test * resolve merge conflicts * Merge branch 'proposer-and-attester-slashing-sse-events' of https://github.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events * leftover debugging * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * pin macos release runner to `macos-13` (#5665) * pin macos release runner to `macos-13` * Update .github/workflows/release.yml * Remove snapshot cache related code (#5661) * Remove snapshot cache and other references. * Fix default state cache size in docs * Remove cache miss comment entirely * Add state cache CLI tests * Uncomment self_hosted_runner after PR Merge #5137 (#5291) * Uncomment self_hosted_runner after PR Merge #5137 * Merge branch 'unstable' into fix_todo * Merge branch 'unstable' of https://github.com/sigp/lighthouse into fix_todo * Only `portable` builds (binaries) (#5615) * release workflow: portable builds by default * Delete outdated comment * Merge branch 'unstable' into portable-builds-binaries # Conflicts: # .github/workflows/release.yml * Merge parent and current sync lookups (#5655) * Drop lookup type trait for a simple arg * Drop reconstructed for processing * Send parent blocks one by one * Merge current and parent lookups * Merge current and parent lookups clean up todos * Merge current and parent lookups tests * Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup * Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup * fix compile after merge * #5655 pr review (#26) * fix compile after merge * remove todos, fix typos etc * fix compile * stable rng * delete TODO and unfilled out test * make download result a struct * enums instead of bools as params * fix comment * Various fixes * Track ignored child components * Track dropped lookup reason as metric * fix test * add comment describing behavior of avail check error * update ordering * delete spammy log (#5672) * delete spammy log * Ensure block only range requests don't fail on download (#5675) * ensure pruned blobs don't fail on download * Typo * Improve ENR updates (#5483) * Improve ENR updates * forever fmt * Appease my old friend clippy * Merge network unstable * Check da_checker before doing a block lookup request (#5681) * Check da_checker before doing a block lookup request * Ensure consistent handling of lookup result * use req resp pre import cache rather than da checker * Update Cargo.lock (#5670) * update rust-yamux * update Cargo.lock * Merge branch 'unstable' of github.com:jxs/lighthouse into update-cargo * Merge branch 'unstable' of github.com:sigp/lighthouse into update-cargo * update to new libp2p versions * Add metric for current epoch total balance (#5688) * Add metric for current epoch total balance --------- Co-authored-by: realbigsean <sean@sigmaprime.io> Co-authored-by: Mac L <mjladson@pm.me> Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com> Co-authored-by: Pawan Dhananjay <pawandhananjay@gmail.com> Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com> Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu> Co-authored-by: antondlr <anton@delaruelle.net> Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> Co-authored-by: Ærvin <arvin.morawej@gmail.com> Co-authored-by: Age Manning <Age@AgeManning.com> Co-authored-by: João Oliveira <hello@jxs.pt> Co-authored-by: Michael Sproul <michael@sigmaprime.io>

antondlr added ready-for-review The code is ready for review infra-ci v5.2.0 Q2 2024 labels Apr 22, 2024

This was referenced Apr 22, 2024

Use portable builds by default #5489

Closed

Docker build failing on x86_64_dev since moving to the c-kzg from crate-io #5572

Closed

michaelsproul mentioned this pull request Apr 24, 2024

Bump jobserver and fix non-portable builds #5641

Merged

release workflow: portable builds by default

67a88a2

antondlr force-pushed the portable-builds-binaries branch from d086778 to 67a88a2 Compare April 24, 2024 07:05

michaelsproul reviewed Apr 28, 2024

View reviewed changes

michaelsproul approved these changes Apr 28, 2024

View reviewed changes

michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 28, 2024

michaelsproul reviewed Apr 30, 2024

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

Delete outdated comment

4f539f2

michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 30, 2024

michaelsproul mentioned this pull request Apr 30, 2024

Release v5.2.0 #5664

Merged

antondlr mentioned this pull request Apr 30, 2024

pin macos release runner to macos-13 #5665

Merged

Merge branch 'unstable' into portable-builds-binaries

a70964d

# Conflicts: # .github/workflows/release.yml

mergify bot added a commit that referenced this pull request Apr 30, 2024

Merge of #5615

052ed5e

mergify bot mentioned this pull request Apr 30, 2024

merge queue: embarking unstable (63fad7e) and #5615 together #5669

Closed

5 tasks

mergify bot added a commit that referenced this pull request Apr 30, 2024

Merge of #5615

1666f10

This was referenced Apr 30, 2024

merge queue: embarking unstable (aea02c6) and [#5615 + #5655] together #5673

Closed

Merge parent and current sync lookups #5655

Merged

mergify bot merged commit 196d9fd into sigp:unstable Apr 30, 2024
27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only `portable` builds (binaries) #5615

Only `portable` builds (binaries) #5615

antondlr commented Apr 22, 2024

michaelsproul Apr 28, 2024

michaelsproul left a comment

michaelsproul commented Apr 30, 2024

mergify bot commented Apr 30, 2024

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024 •

edited

Loading

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024

mergify bot commented Apr 30, 2024 •

edited

Loading

Only portable builds (binaries) #5615

Only portable builds (binaries) #5615

Conversation

antondlr commented Apr 22, 2024

michaelsproul Apr 28, 2024

Choose a reason for hiding this comment

michaelsproul left a comment

Choose a reason for hiding this comment

michaelsproul commented Apr 30, 2024

mergify bot commented Apr 30, 2024

🛑 The pull request has been removed from the queue default

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024

🛑 The pull request has been removed from the queue default

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented Apr 30, 2024 • edited Loading

✅ The pull request has been merged automatically

Only `portable` builds (binaries) #5615

Only `portable` builds (binaries) #5615

🛑 The pull request has been removed from the queue `default`

mergify bot commented Apr 30, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

🛑 The pull request has been removed from the queue `default`

mergify bot commented Apr 30, 2024 •

edited

Loading