Break off a fulcioroot package.
#639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cosigned` webhook pulls in the Fulcio roots, and runs as a K8s controller, which consumes `klog`. However, some of the certificate transparency stuff the Fulcio package pulls in consumes `glog`. These both define conflicting `-log_dir` flags, which cause `cosigned` to crash on startup. With this change, `cosigned` can use `fulcioroots.Get` to load the roots without pulling in `glog`. In a subsequent change, I have tests that should catch this before a breaking change merges. Signed-off-by: Matt Moore <mattomata@gmail.com>
dlorenc
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cosignedwebhook pulls in the Fulcio roots, and runs as a K8s controller, which consumesklog. However, some of the certificate transparency stuff the Fulcio package pulls in consumesglog. These both define conflicting-log_dirflags, which causecosignedto crash on startup.With this change,
cosignedcan usefulcioroots.Getto load the roots without pulling inglog.In a subsequent change, I have tests that should catch this before a breaking change merges.
Signed-off-by: Matt Moore mattomata@gmail.com