Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break off a fulcioroot package. #639

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Break off a fulcioroot package. #639

merged 1 commit into from
Sep 8, 2021

Commits on Sep 8, 2021

  1. Break off a fulcioroot package. 

    The `cosigned` webhook pulls in the Fulcio roots, and runs as a K8s controller, which consumes `klog`.  However, some of the certificate transparency stuff the Fulcio package pulls in consumes `glog`.  These both define conflicting `-log_dir` flags, which cause `cosigned` to crash on startup.

With this change, `cosigned` can use `fulcioroots.Get` to load the roots without pulling in `glog`.

In a subsequent change, I have tests that should catch this before a breaking change merges.

Signed-off-by: Matt Moore <mattomata@gmail.com>
    @mattmoor
    mattmoor committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    88db463 View commit details
    Browse the repository at this point in the history