-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical scrolling missing from asset details #1163
Comments
Replicated issue on 4.7.0-rc1 using chrome 87 on ubuntu It seems like it's only chrome 87 (and any other chromium based browser) that has this issue Using browser stack with different versions of chrome for windows silverstripe/recipe-cms 4.6.2 chrome silverstripe/recipe-cms 4.5.2 chrome edge Looks like setting any value on the fieldset mentioned in the previous comment is enough to fix this as it's a layout engine bug, even max-height: inherit works, as does height: 200% or height: 10px; It's probably this specifically which is in chromium 88 https://chromium.googlesource.com/chromium/src/+/0be9d57db0fc18e6cc2b9a9be6362f784bda8654 |
We've spent a fair bit of time investigating this issue and we've deemed it an issue with chrome, rather than an issue with silverstripe We were able to replicate this issue on chrome 87.0.4280.66, however not on 87.0.4280.88 I'm going to mark this issue as closed since we won't be fixing it ourselves and we'll instead we'll rely on automatic browser updates. If it's critically important that you fix this yourself on one of your projects, this closed PR has one-liner of CSS that can be added that seems like it fixes the issue |
Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163
Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163
Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163
Allow Behat smoke test failures for now Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163 ENHANCEMENT: Code gen stores entire config array Context provider refactor Refactor nested plugins as a service Get rid of build state Get builds working Sorting and filtering working with new context providers simplify dataobject resolve, get rid of default resolvers Rebase, tests passing New ResolverFailure, resolverComposition for better error handling
Allow Behat smoke test failures for now Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163 ENHANCEMENT: Code gen stores entire config array Context provider refactor Refactor nested plugins as a service Get rid of build state Get builds working Sorting and filtering working with new context providers simplify dataobject resolve, get rid of default resolvers Rebase, tests passing New ResolverFailure, resolverComposition for better error handling Fix schema context psr-4, queryhandlerinterface contract Fix aliases in create/update, add massive integration test Linting
Allow Behat smoke test failures for now Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163 ENHANCEMENT: Code gen stores entire config array Context provider refactor Refactor nested plugins as a service Get rid of build state Get builds working Sorting and filtering working with new context providers simplify dataobject resolve, get rid of default resolvers Rebase, tests passing New ResolverFailure, resolverComposition for better error handling Fix schema context psr-4, queryhandlerinterface contract Fix aliases in create/update, add massive integration test Linting Add test for aggregate function
Allow Behat smoke test failures for now Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163 ENHANCEMENT: Code gen stores entire config array Context provider refactor Refactor nested plugins as a service Get rid of build state Get builds working Sorting and filtering working with new context providers simplify dataobject resolve, get rid of default resolvers Rebase, tests passing New ResolverFailure, resolverComposition for better error handling Fix schema context psr-4, queryhandlerinterface contract Fix aliases in create/update, add massive integration test Linting Add test for aggregate function
Allow Behat smoke test failures for now Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163 ENHANCEMENT: Code gen stores entire config array Context provider refactor Refactor nested plugins as a service Get rid of build state Get builds working Sorting and filtering working with new context providers simplify dataobject resolve, get rid of default resolvers Rebase, tests passing New ResolverFailure, resolverComposition for better error handling Fix schema context psr-4, queryhandlerinterface contract Fix aliases in create/update, add massive integration test Linting Add test for aggregate function
Allow Behat smoke test failures for now Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163 ENHANCEMENT: Code gen stores entire config array Context provider refactor Refactor nested plugins as a service Get rid of build state Get builds working Sorting and filtering working with new context providers simplify dataobject resolve, get rid of default resolvers Rebase, tests passing New ResolverFailure, resolverComposition for better error handling Fix schema context psr-4, queryhandlerinterface contract Fix aliases in create/update, add massive integration test Linting Add test for aggregate function
Allow Behat smoke test failures for now Upstream is broken, and it's out of our control to fix (Chrome bug) - see silverstripe/silverstripe-asset-admin#1163 ENHANCEMENT: Code gen stores entire config array Context provider refactor Refactor nested plugins as a service Get rid of build state Get builds working Sorting and filtering working with new context providers simplify dataobject resolve, get rid of default resolvers Rebase, tests passing New ResolverFailure, resolverComposition for better error handling Fix schema context psr-4, queryhandlerinterface contract Fix aliases in create/update, add massive integration test Linting Add test for aggregate function
On Chrome 87/Edge 88 the asset details panel is missing the vertical scroll bar:
Using the scroll wheel etc doesn't allow the panel to be scrolled either.
The text was updated successfully, but these errors were encountered: