Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Travis shared config #332

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 30, 2020

Mergeup to 3 AND 4

Behat failure is an issue with chrome that we've investigated and we'll let browser auto updates deal with silverstripe/silverstripe-asset-admin#1163

Behat screenshot:
https://s3.amazonaws.com/silverstripe-travis-artifacts/silverstripe/silverstripe-graphql/208443105/459249264/screenshots/insert-an-image.feature_46.png

@emteknetnz emteknetnz force-pushed the pulls/3.4/travis-shared branch 3 times, most recently from e8d6da4 to 87876fc Compare December 1, 2020 21:38
@emteknetnz emteknetnz force-pushed the pulls/3.4/travis-shared branch 2 times, most recently from 125d8ed to 8435149 Compare December 10, 2020 22:08
@emteknetnz emteknetnz force-pushed the pulls/3.4/travis-shared branch from 8435149 to a9bb773 Compare December 13, 2020 21:22
@Cheddam
Copy link
Member

Cheddam commented Dec 21, 2020

I'm not convinced that the Behat failure relates to the styling issue presented in that screenshot - it looks like the test is trying to find a button in the DOM and failing:

And I press the "Details" button                                # SilverStripe\BehatExtension\Context\BasicContext::stepIPressTheButton()

      Details button not found

      Failed asserting that null is not null.

I'll spend a bit of time trying to reproduce locally, would prefer not to merge red if possible.

@emteknetnz
Copy link
Member Author

@Cheddam the issue is actually on asset-admin as graphql runs behat tests from different modules.

I've written an explanation on the asset-admin PR of why I think this should be merged as is

@Cheddam Cheddam merged commit 8932f7b into silverstripe:3.4 Jan 14, 2021
@Cheddam Cheddam deleted the pulls/3.4/travis-shared branch January 14, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants