DEP Upgrade front-end build stack #1032
Conversation
| preview.entwine('ss.preview')._loadUrl(preview.find('iframe').attr('src')); | ||
| if (preview && typeof preview.entwine === 'function') { | ||
| preview.entwine('ss.preview')._loadUrl(preview.find('iframe').attr('src')); | ||
| } |
There was a problem hiding this comment.
Required for testing purposes, where we don't actually have jquery with entwine in the DOM.
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
See silverstripe/silverstripe-asset-admin#1320 (comment) for explanation of this file
GuySartorelli
force-pushed
the
pulls/5/frontend-build-stack
branch
from
b5fca9e to
8a7ccd4
Compare
| jest.mock('isomorphic-fetch', () => | ||
| () => Promise.resolve({ | ||
| json: () => ({}), | ||
| }) | ||
| ); | ||
|
|
There was a problem hiding this comment.
Taken from TreeDropdownField-test.js to avoid ReferenceError: TextEncoder is not defined when running jest tests. See this stackoverflow question for more details about this error and its causes.
|
Failing unit test is unrelated. |
GuySartorelli
force-pushed
the
pulls/5/frontend-build-stack
branch
from
8a7ccd4 to
b627a86
Compare
| Then I should see a "Saved 'Charlie's Block' successfully" notice | ||
| Then I should see a "Saved 'Charlie's Block' successfully" success toast |
There was a problem hiding this comment.
The "I should see some notice" fixture was removed, as it had previously been deprecated. See silverstripe/silverstripe-framework#10594
GuySartorelli
force-pushed
the
pulls/5/frontend-build-stack
branch
from
b627a86 to
7a84632
Compare
| @@ -4,14 +4,11 @@ | |||
| use DNADesign\Elemental\Models\BaseElement; | |||
| use DNADesign\Elemental\Models\ElementalArea; | |||
| use DNADesign\Elemental\Models\ElementContent; | |||
| use SilverStripe\BehatExtension\Context\FixtureContext as BaseFixtureContext; | |||
| use SilverStripe\CMS\Tests\Behaviour\FixtureContext as BaseFixtureContext; | |||
There was a problem hiding this comment.
Necessary to include the anchor dropdown fixture method - we can't just add the SilverStripe\CMS\Tests\Behaviour\FixtureContext class to the fixtures in behat.yml because it has the same superclass as this one, which causes behat to fail since it doesn't know whether to call methods from this fixture class or the CMS one.
Using the CMS fixture class as the superclass here resolves that problem.
GuySartorelli
force-pushed
the
pulls/5/frontend-build-stack
branch
3 times, most recently
from
7b6d468 to
3b3ec46
Compare
| Examples: | ||
| | group | | ||
| | ADMIN | | ||
| | AUTHOR | |
There was a problem hiding this comment.
The scenario outline wasn't actually using these variables. See the docs on scenario outlines
There's no reason to use admin here anyway so it makes more sense to just remove the examples and change the outline to a normal scenario.
| When I press the "tab" key globally | ||
| Then I should not see "Duplicate" | ||
| And I should see a ".tox-tinymce" element |
There was a problem hiding this comment.
There was an issue where the block expansion was being affected by this menu button
| When I press the "space" key globally | ||
| Then I should see "Duplicate" | ||
| And I should see a ".tox-tinymce" element | ||
| When I press the "escape" key globally |
There was a problem hiding this comment.
An update to bootstrap and/or reactstrap has changed the behaviour to give focus to the first element in the dropdown when opening with the keyboard, so we need to use escape to close it rather than hitting space/enter again.
|
Behat passes locally - I'll set up a full kitchen sink run (link in the main issue) with all of the PRs running all of the behat to show whether this actually passes with all of the changes applied. |
GuySartorelli
force-pushed
the
pulls/5/frontend-build-stack
branch
from
3b3ec46 to
bfed1ab
Compare
See silverstripe/silverstripe-admin#1389 for a wider discussion on most of the changes
Parent issue