DEP Use webonyx/graphq-php 15 #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
force-pushed
the
pulls/5/webonyx-15
branch
from
826b1b9 to
1149129
Compare
|
Elemental was made cms5 compatible in the first run - BUT it's JavaScript hasn't been updated yet which is causing the behat failures. |
maxime-rainville
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #511
I've added an extra job to PHP 8.2 in CI
Behat failure for elemental job I believe is because elemental is not yet CMS 5 compatible? I get the same error locally running both PHP 8.1 and PHP 8.2 with the the old v14 of webonyx/graphql.