Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Remove deprecated template vars #10782

Conversation

satrun77
Copy link
Contributor

Remove deprecated template variables from get_template_iterator_variables The methods already removed from #10594

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that! Please retarget this PR to the 5.0 branch - this should be released as a patch.

@satrun77 satrun77 changed the base branch from 5 to 5.0 May 16, 2023 03:03
@satrun77 satrun77 force-pushed the pulls/5.0/remove-deprecated-template-vars branch from c2325b6 to b51bc42 Compare May 16, 2023 03:05
@satrun77
Copy link
Contributor Author

@GuySartorelli Done

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge on green

@GuySartorelli GuySartorelli merged commit 4a2dc2d into silverstripe:5.0 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants