API Remove deprecated code #10594
Merged
API Remove deprecated code #10594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
sabina-talipova
force-pushed
the
pulls/5/remove-deprecated-code
branch
2 times, most recently
from
5649de4 to
4a2fcda
Compare
|
Failed CI requires asset-admin PR should be merged before |
sabina-talipova
force-pushed
the
pulls/5/remove-deprecated-code
branch
2 times, most recently
from
c9fad42 to
7c0ffa6
Compare
emteknetnz
requested changes
Dec 5, 2022
| @@ -357,11 +356,6 @@ public function transactionEnd($chain = false) | |||
| { | |||
| $result = $this->getTransactionManager()->transactionEnd(); | |||
|
|
|||
| if ($chain) { | |||
There was a problem hiding this comment.
Remove the $chain param from the method
There was a problem hiding this comment.
I removed $chain argument from Database::transactionEnd() method.
We should mark $chain as deprecated in Database::transactionEnd() for 4.12 as well.
There was a problem hiding this comment.
Have you created a PR to add the deprecation in 4.12?
You'll also need to deprecated it for NullDatabase::transactionEnd()
There was a problem hiding this comment.
I've created new tickets for this #10609
sabina-talipova
force-pushed
the
pulls/5/remove-deprecated-code
branch
3 times, most recently
from
80c3638 to
c231c96
Compare
sabina-talipova
force-pushed
the
pulls/5/remove-deprecated-code
branch
from
c231c96 to
3b87605
Compare
emteknetnz
approved these changes
Dec 7, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue