Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLN Update translations #11125

Merged
merged 1 commit into from
Feb 6, 2024
Merged

TLN Update translations #11125

merged 1 commit into from
Feb 6, 2024

Conversation

GuySartorelli
Copy link
Member

Automated translations update generated using silverstripe/tx-translator

@GuySartorelli GuySartorelli mentioned this pull request Feb 6, 2024
Closed
emteknetnz
emteknetnz reviewed Feb 6, 2024
View reviewed changes
lang/en.yml Outdated
@@ -1,4 +1,6 @@
en:
DevelopmentAdmin:
php.SilverStripe\Dev\DevelopmentAdminPERMISSIONS_CATEGORY: 'Dev permissions'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right

There's a missing dot here - could you please add it and re-run translations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed, and raised an issue to make a phpstan rule to catch these in CI in the future.

@emteknetnz emteknetnz merged commit 26273bf into silverstripe:5 Feb 6, 2024
15 checks passed
@emteknetnz emteknetnz deleted the pulls/5/tx-1707252767 branch February 6, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz