FIX Ensure schema data includes attributes #11469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes attributes in
getSchemaDataDefaults()
(excluding any duplicates and thevalue
attribute, which would have caused problems).To test
Assuming you have
silverstripe/frameworktest
installed:Add this code to the
Company
classGo to the "Test ModelAdmin" section (
/admin/test
)Click the magnifying glass in the top right, then expand "search options" - the "Name" field should have some placeholder text.
Also check that you can set up and use the formfields which were specifically changed.
Issue