FIX Avoid infinite recursive loop with attributes in schemadata #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/4/schemadata-attributes
branch
from
d6bc04c to
f2c79d2
Compare
GuySartorelli
force-pushed
the
pulls/4/schemadata-attributes
branch
from
f2c79d2 to
7c4f39c
Compare
GuySartorelli
force-pushed
the
pulls/4/schemadata-attributes
branch
from
7c4f39c to
c70bfbe
Compare
GuySartorelli
commented
Nov 20, 2024
Comment on lines
+416
to
+417
| $form = new Form(); | ||
| $field->setForm($form); |
There was a problem hiding this comment.
Without this we get the following error due to calling getSchemaState() which we didn't used to call:
LogicException: Field must be associated with a form to call Link(). Please use $field->setForm($form);
emteknetnz
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects changes in silverstripe/silverstripe-framework#11469 - that may need to be merged for CI to go green.
Issue