Remedy deprecated dynamic variable declaration #354
Conversation
There was a problem hiding this comment.
dynamic properties are public - these new properties must also be public to avoid backwards compatibility issues.
Please remove the default values - there are no default for dynamic properties, which these are replacing.
Please also target the 4.0 branch - ideally this change will be released as a patch release.
|
Thought I might be able to batch commit the suggestions from GH UI, but no dice. |
|
@alex-dna There are some requested changes on this PR - do you still want to have this change merged in? |
Co-authored-by: Michal Kleiner <mk@011.nz>
Co-authored-by: Michal Kleiner <mk@011.nz>
|
@GuySartorelli I've committed the requested changes. Thanks @michalkleiner . This is ow targetting the right branch I think. |
There was a problem hiding this comment.
Looks okay to me now. Thanks for that.
@michalkleiner do you have any concerns? (other than the merge commits in there, but I'll just squash-and-merge if you're happy with it)
There was a problem hiding this comment.
All good from my perspective, thanks @alex-dna and @GuySartorelli
This should prevent warning to be triggered by php 8.2