Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remedy deprecated dynamic variable declaration #354

Merged
merged 10 commits into from
Jan 15, 2024
Merged

Remedy deprecated dynamic variable declaration #354

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c954b68
Merge branch '4.0' into 4
emteknetnz Mar 2, 2023
d35de05
Merge branch '4.0' into 4
emteknetnz Mar 30, 2023
ac7db94
Merge branch '4.0' into 4
emteknetnz May 4, 2023
a4def05
Merge branch '4.0' into 4
emteknetnz May 30, 2023
e00a8ea
Merge branch '4.0' into 4
emteknetnz May 31, 2023
0f62997
Merge branch '4.0' into 4
GuySartorelli Aug 28, 2023
7635345
Remedy deprecated dynamic variable declaration
alex-dna Dec 20, 2023
9ae64b4
Update SolrConfigStore_File.php
alex-dna Dec 20, 2023
f4d3272
Update src/Solr/Stores/SolrConfigStore_File.php
alex-dna Jan 15, 2024
9aaf67e
Update src/Solr/Stores/SolrConfigStore_WebDAV.php
alex-dna Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Solr/Stores/SolrConfigStore_File.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,19 @@
*/
class SolrConfigStore_File implements SolrConfigStore
{
/**
* @var string
*/
protected $remote = '';

/**
* @var string
*/
protected $local = '';
alex-dna marked this conversation as resolved.
Show resolved Hide resolved

/**
* @param array $config
*/
public function __construct($config)
{
$this->local = $config['path'];
Expand Down Expand Up @@ -49,4 +62,4 @@ public function instanceDir($index)
{
return $this->remote . '/' . $index;
}
}
}
alex-dna marked this conversation as resolved.
Show resolved Hide resolved
13 changes: 13 additions & 0 deletions src/Solr/Stores/SolrConfigStore_WebDAV.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,19 @@
*/
class SolrConfigStore_WebDAV implements SolrConfigStore
{
/**
* @var string
*/
protected $remote = '';

/**
* @var string
*/
protected $url = '';
alex-dna marked this conversation as resolved.
Show resolved Hide resolved

/**
* @param array $config
*/
public function __construct($config)
{
$options = Solr::solr_options();
Expand Down