Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: GUID Transformation #18

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Add: GUID Transformation #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/en/developer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ We assume ADFS 2.0 or greater is used as an IdP.
- [Service Provider (SP)](#service-provider-sp)
- [Identity Provider (IdP)](#identity-provider-idp)
- [Additional configuration for Azure AD](#additional-configuration-for-azure-ad)
- [GUID Transformation](#guid-transformation)
- [Establish trust](#establish-trust)
- [Configure SilverStripe Authenticators](#configure-silverstripe-authenticators)
- [Show the SAML Login button on login form](#show-the-saml-login-button-on-login-form)
Expand Down Expand Up @@ -149,6 +150,11 @@ SilverStripe\SAML\Extensions\SAMLMemberExtension:
- 'http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name': 'Email'
```

### GUID Transformation

If you prefer to receive the GUID in lower-case or upper-case format you can use the
`updateGuid()` extension point on `\SilverStripe\SAML\Control\SAMLController`.

## Establish trust

At this stage the SilverStripe site trusts the IdP, but the IdP does not have any way to establish the identity of the SilverStripe site.
Expand Down
4 changes: 3 additions & 1 deletion src/Control/SAMLController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,15 @@ public function acs()
}

if (!$helper->validGuid($guid)) {
$errorMessage = "Not a valid GUID '{$guid}' recieved from server.";
$errorMessage = "Not a valid GUID '{$guid}' received from server.";
$this->getLogger()->error($errorMessage);
$this->getForm()->sessionMessage($errorMessage, ValidationResult::TYPE_ERROR);
$this->getRequest()->getSession()->save($this->getRequest());
return $this->getRedirect();
}

$this->extend('updateGuid', $guid);

$attributes = $auth->getAttributes();

$fieldToClaimMap = array_flip(Member::config()->claims_field_mappings);
Expand Down