Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Add rule to catch malformed _t() calls #12

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

GuySartorelli
Copy link
Member

This should catch cases where keys in calls to _t() (either globally or via i18n::_t() directly) are malformed. It'll also catch some cases where the text collector wouldn't be able to correctly evaluate the key.

Issue

@GuySartorelli GuySartorelli marked this pull request as draft August 6, 2024 01:01
@GuySartorelli GuySartorelli force-pushed the pulls/1/i18n-rule branch 2 times, most recently from 7c9c388 to 0c46fd4 Compare August 6, 2024 02:04
@GuySartorelli GuySartorelli marked this pull request as ready for review August 6, 2024 02:08
@emteknetnz emteknetnz merged commit 8364579 into silverstripe:1 Aug 6, 2024
8 checks passed
@emteknetnz emteknetnz deleted the pulls/1/i18n-rule branch August 6, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants