Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DomainSlider to DomainWidget #1445

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Rename DomainSlider to DomainWidget #1445

merged 1 commit into from
Jun 13, 2023

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jun 7, 2023

First step in addressing #1382 and #1377. This is a breaking change, obviously. The idea is to then rename ScaledSlider to DomainSlider and export it.

The end goal is to have the following components exported:

  • DomainWidget: the whole toolbar control that allows choosing a custom domain (i.e. slider + tooltip);
  • DomainSlider: the actual slider;
  • DomainControls: the content of the tooltip (bounds inputs + auto-scale buttons).

The tooltip behaviour will remain the responsibility of DomainWidget.

I haven't renamed the CSS variables for now -- I'll do it after I rename/create the other components.

@axelboc axelboc force-pushed the rename-domain-slider branch 2 times, most recently from be79d58 to 1d92009 Compare June 7, 2023 13:51
@axelboc axelboc changed the base branch from main to domain-widget June 7, 2023 13:55
@axelboc
Copy link
Contributor Author

axelboc commented Jun 7, 2023

I've created a branch called domain-widget into which I'll merge this and the next PRs. I won't merge domain-widget into main until we're ready for another major release.

@axelboc axelboc requested a review from loichuder June 7, 2023 13:56
@loichuder
Copy link
Member

We already have #1439 which is technically a breaking change so you can merge to main if you wish.

@axelboc axelboc changed the base branch from domain-widget to main June 8, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants