Rename DomainSlider
to DomainWidget
#1445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in addressing #1382 and #1377. This is a breaking change, obviously. The idea is to then rename
ScaledSlider
toDomainSlider
and export it.The end goal is to have the following components exported:
DomainWidget
: the whole toolbar control that allows choosing a custom domain (i.e. slider + tooltip);DomainSlider
: the actual slider;DomainControls
: the content of the tooltip (bounds inputs + auto-scale buttons).The tooltip behaviour will remain the responsibility of
DomainWidget
.I haven't renamed the CSS variables for now -- I'll do it after I rename/create the other components.