Rename DomainTooltip to DomainControls and move tooltip logic to DomainWidget
#1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
changed the title
DomainTooltip to DomainControls and move tooltip logic to DomainWidget
axelboc
commented
Jul 19, 2023
loichuder
approved these changes
Jul 19, 2023
| ); | ||
| }); | ||
|
|
||
| DomainControls.displayName = 'DomainControls'; |
There was a problem hiding this comment.
It's because React loses the name of components encapsulated by forwardRef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third step (after #1445 and #1448) in addressing #1382 and #1377.
In the first commit,
DomainTooltipbecomesDomainControlsand the tooltip logic moves up intoDomainWidget. In the second commit, I exportDomainControlsand document it in Storybook:The final step will be to double check if any of the CSS customisation properties need to be renamed.