Add SZ #206

vasole · 2022-11-22T13:17:12Z

Include and completes #203

git-subtree-dir: src/SZ git-subtree-split: 5857c6ed1f7a8ca1c2822a88e2f614e466dc4d34

"Working" version of SZ without using CMake

# Conflicts: # setup.py

vasole · 2022-11-22T15:23:41Z

At this point, the code compiles under all the platforms and the test file supplied by @orioltinto is properly read.

Still missing tests.

…allclose function.

Add SZ: Docstrings, self-explanatory arguments and default value.

src/hdf5_dl.c

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

src/hdf5_dl.c

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

src/hdf5_dl.c

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

setup.py

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

setup.py

t20100

LGTM, I left a few suggestions.
There is probably a few things to change in setup.py but that can be done in another PR.

src/hdf5plugin/_filters.py

src/hdf5plugin/test.py

src/hdf5plugin/_filters.py

doc/information.rst

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

orioltinto and others added 19 commits October 27, 2022 15:51

Adding SZ

53ef7a1

Squashed 'src/SZ/' content from commit 5857c6e

40e3ee3

git-subtree-dir: src/SZ git-subtree-split: 5857c6ed1f7a8ca1c2822a88e2f614e466dc4d34

Merge commit '40e3ee35ad7c5158b2184aed925ac7c9f1b293bc' as 'src/SZ'

2a4e9ea

Adding -lzstd in sz_lib flags.

356e7b5

Compiling SZ using cmake.

3e9df6a

Working version

f207d89

Merge pull request #1 from orioltinto/SZ

beeb48f

"Working" version of SZ without using CMake

Removing CMake stuff

f14128d

Remove useless class

7e29568

Add SZ class into hdf5plugin.__init__.py .

7fdc21d

Running SZ configure from setup.py.

4f17fa5

Fixes in SZ setup.py

99813ef

Merge remote-tracking branch 'base/main' into main

8856718

# Conflicts: # setup.py

Add again the piece to execute SZ's configure in setup.py

d8492f6

Merge branch 'main' of https://github.com/orioltinto/hdf5plugin into SZ

d4aa051

Update to SZ commit 3fa63cea8e34c8c3f3f229c9118ce0937eff5a73

072de5c

Revert config.h changes to match PR 103 of SZ.

4831ca5

Add windows config.h

5a321a7

Relocate SZ in _filters.py

206fe59

vasole mentioned this pull request Nov 22, 2022

Adding SZ HDF5 filter #203

Closed

Try to get things working under MacOS

d1c8cfe

vasole changed the title ~~Add SZ~~ [WIP] Add SZ Nov 22, 2022

vasole added 4 commits November 22, 2022 14:44

Define to 1.

11f5be7

Try to use ZLIB from blosc.

1a83e64

Adapt to MacOS

67657d5

Take zlib from blosc

3e8081f

vasole added 3 commits November 22, 2022 17:18

Load the filter

ec35afd

Change the flag

5662705

Add test file from SZ repository.

734ab33

orioltinto and others added 5 commits November 22, 2022 18:50

Set SZ's default value to pointwise_relative=1e-05 following numpy's …

4ddf318

…allclose function.

Update test for new argument names.

4d6aa02

Merge pull request #209 from orioltinto/SZ

27596fd

Add SZ: Docstrings, self-explanatory arguments and default value.

Assertion not needed

677cf6a

Add SZ to the list.

529786d

t20100 reviewed Nov 23, 2022

View reviewed changes

src/hdf5_dl.c Outdated Show resolved Hide resolved

vasole and others added 3 commits November 23, 2022 10:02

Update src/hdf5_dl.c

e208c1d

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

Suppress missing platform.

f4b8025

Merge branch 'SZ' of https://github.com/silx-kit/hdf5plugin into SZ

ce9de4f

t20100 reviewed Nov 23, 2022

View reviewed changes

src/hdf5_dl.c Outdated Show resolved Hide resolved

Update src/hdf5_dl.c

eaf4f90

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

t20100 reviewed Nov 23, 2022

View reviewed changes

src/hdf5_dl.c Outdated Show resolved Hide resolved

Update src/hdf5_dl.c

facdef5

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

t20100 reviewed Nov 23, 2022

View reviewed changes

setup.py Outdated Show resolved Hide resolved

Update setup.py

f188705

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

t20100 reviewed Nov 23, 2022

View reviewed changes

setup.py Show resolved Hide resolved

vasole added 2 commits November 23, 2022 10:24

License and references.

81cd6e8

Merge branch 'SZ' of https://github.com/silx-kit/hdf5plugin into SZ

73712af

t20100 approved these changes Nov 23, 2022

View reviewed changes

src/hdf5plugin/_filters.py Outdated Show resolved Hide resolved

src/hdf5plugin/test.py Outdated Show resolved Hide resolved

src/hdf5plugin/_filters.py Outdated Show resolved Hide resolved

doc/information.rst Outdated Show resolved Hide resolved

vasole and others added 4 commits November 23, 2022 10:30

Typo

df11dc0

Update src/hdf5plugin/_filters.py

ea25df6

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

Update src/hdf5plugin/test.py

dfa1e4f

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

Update src/hdf5plugin/_filters.py

8433038

Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>

t20100 added this to the 4.0.0 milestone Nov 23, 2022

t20100 merged commit daf5703 into main Nov 23, 2022

vasole deleted the SZ branch November 23, 2022 10:54

This was referenced Nov 23, 2022

Better warning about Windows not being supported? szcompressor/SZ#91

Open

Adding SZ? #195

Closed

This was referenced Nov 24, 2022

Updated SZ support #213

Merged

Updated SZ build #215

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SZ #206

Add SZ #206

vasole commented Nov 22, 2022

vasole commented Nov 22, 2022

t20100 left a comment

Add SZ #206

Add SZ #206

Conversation

vasole commented Nov 22, 2022

vasole commented Nov 22, 2022

t20100 left a comment

Choose a reason for hiding this comment