Updated SZ support #213
Merged
Updated SZ support #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Nov 25, 2022
Comment on lines
-483
to
+488
| packed_error = self.pack_error(parameter) | ||
| compression_opts = (sz_mode, *packed_error, *packed_error, *packed_error, *packed_error) | ||
| compression_opts = ( | ||
| sz_mode, | ||
| *self.__pack_float64(absolute or 0.), | ||
| *self.__pack_float64(relative or 0.), | ||
| *self.__pack_float64(pointwise_relative or 0.), | ||
| *self.__pack_float64(0.), # psnr | ||
| ) |
There was a problem hiding this comment.
Previous implementation was working because not all options are used depending on the mode, but this better matches the meaning of the compression_opts
t20100
commented
Nov 25, 2022
Comment on lines
-492
to
+500
| def pack_error(error: float) -> tuple: | ||
| packed = struct.pack('<d', error) # Pack as IEEE 754 double | ||
| high = struct.unpack('<I', packed[0:4])[0] # Unpack high bits as unsigned int | ||
| low = struct.unpack('<I', packed[4:8])[0] | ||
| return low, high | ||
| def __pack_float64(error: float) -> tuple: | ||
| packed = struct.pack('>d', error) # Pack as big-endian IEEE 754 double | ||
| high = struct.unpack('>I', packed[0:4])[0] # Unpack most-significant bits as unsigned int | ||
| low = struct.unpack('>I', packed[4:8])[0] # Unpack least-significant bits as unsigned int | ||
| return high, low |
There was a problem hiding this comment.
Same here previous implementation was working but the C code state working with big endian, so let's match it too.
BTW, that would be good to check it on a big-endian machine.
t20100
commented
Nov 25, 2022
Comment on lines
-340
to
341
| status = hdf5plugin.register() | ||
| self.assertTrue(status) | ||
| hdf5plugin.register() | ||
| for filter_name in BUILD_CONFIG.embedded_filters: |
There was a problem hiding this comment.
The assert fails if not all filters are embedded (by using HDF5PLUGIN_STRIP)
t20100
commented
Nov 25, 2022
|
attn @orioltinto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #206 to add and update a few things.