Allow taking an snapshot of a local file

[pjamargh]

For an .html file stored locally I use python -m http.server 80 and then shot-scraper http://localhost/file but it would be handy to be able to just point shot-scraper to the file directly.

[simonw]

I agree, this would definitely be useful.

[simonw]

Deleting this check:

shot-scraper/shot_scraper/cli.py

Lines 352 to 355 in 773377e

	if not (url.startswith("http://") or url.startswith("https://")):
	raise click.ClickException(
	"'url' must start http:// or https:// - got: \n{}".format(url)
	)

And then running the following worked:

shot-scraper file:/tmp/index.html

I had to provide both file:/ and a full path to the file though.

So the actual implementation of that should probably notice when the user provides a URL that doesn't start with http:// or https:// AND is a file that exists on disk and, if so, do the work of turning that into a file://full/path/to/filename.html.

[pjamargh]

Thanks for the quick response!

Shot-scraper has been a great help for transforming complex epub ebooks into easier to display series of images. Thanks a lot for this tool!

[simonw]

I'm intrigued! Hadn't considered there might be epub applications.

[pjamargh]

They use XHTML. Some are simple (say some images and texts) totally ok to reflow, some are complex. On these last group you have some comics that have images but also transparent text on top so it is readable for accessibility, some others have images without the text and text on top with complex transformations (tilting and such). There are rarely displayed properly in a simple epub reader. I'm still testing but with a little fine fiddling shot-scraper is giving me exactly what I needed (rendering one HTML page into an image).

[simonw]

Tested this out using the Firefox "save complete web page" option on https://daringfireball.net/ and then running:

shot-scraper /tmp/Daring\ Fireball.html --height 1200

Got this output (because I had run it a few times before so the filename had to change):

Screenshot of 'file:/tmp/Daring Fireball.html' written to 'tmp-DaringFireball-html.2.png'

Result:

[pjamargh]

This is great. Thanks a ton, Simon!

…

On Sun, Mar 13, 2022, 10:01 AM Simon Willison ***@***.***> wrote: Closed #35 <#35> via df4498c <df4498c> . — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP46PCMDHKPKFBDDDZHTCZLU7YNPVANCNFSM5QS2HOYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>