Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local files for pdf and accessibility as well #37

Closed
simonw opened this issue Mar 13, 2022 · 2 comments
Closed

Support local files for pdf and accessibility as well #37

simonw opened this issue Mar 13, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Mar 13, 2022

I missed this when I implemented:

@simonw simonw added the enhancement New feature or request label Mar 13, 2022
@simonw
Copy link
Owner Author

simonw commented Mar 13, 2022

I'm going to treat this as a bug, not a new feature, because the documentation already implies that this should work.

@simonw simonw added the bug Something isn't working label Mar 13, 2022
@simonw
Copy link
Owner Author

simonw commented Mar 13, 2022

Got accessibility working:

% shot-scraper accessibility /tmp/Daring\ Fireball.html
{
    "role": "WebArea",
    "name": "Daring Fireball",
    "children": [
        {
            "role": "link",
            "name": "Daring Fireball",
            "description": "Daring Fireball: Home"
        },

And pdf too:

% shot-scraper pdf /tmp/Daring\ Fireball.html          
Screenshot of 'file:/tmp/Daring Fireball.html' written to 'tmp-DaringFireball-html.1.pdf'

@simonw simonw closed this as completed in ac3055f Mar 13, 2022
simonw added a commit that referenced this issue Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant