Throw if the given source file does not exist #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The behavior needs to be documented in the readme and in https://github.com/sindresorhus/cpy/blob/master/index.d.ts |
whitecrownclown
force-pushed
the
feat/throw-no-file
branch
from
27cc72d
to
4b6a98e
Compare
sindresorhus
reviewed
Aug 3, 2019
sindresorhus
reviewed
Aug 3, 2019
sindresorhus
changed the title
sindresorhus
reviewed
Aug 4, 2019
added 2 commits
August 5, 2019 17:53
|
Can you add a test where a glob pattern doesn't match any files? I think the expected behavior there is that it should not throw. |
|
@sindresorhus I've added the test and the previous implementation did throw so I added |
sindresorhus
reviewed
Aug 8, 2019
whitecrownclown
pushed a commit
to whitecrownclown/cpy
that referenced
this pull request
Feb 16, 2020
sindresorhus
pushed a commit
that referenced
this pull request
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sindresorhus
Fixes #50