Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw if the given source file does not exist #68

Merged
merged 13 commits into from
Sep 22, 2019
Merged

Throw if the given source file does not exist #68

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bc4217d
Throw on no file found
Jun 19, 2019
4b6a98e
Update readme
Jun 24, 2019
4651680
Update readme.md
sindresorhus Aug 3, 2019
bba56fe
Update index.d.ts
Aug 4, 2019
7f21b5b
Update no file test
Aug 4, 2019
ce34f30
Update readme.md
sindresorhus Aug 4, 2019
3f87678
Update index.d.ts
sindresorhus Aug 4, 2019
1f0eaa1
Add non-existing multiple files test
Aug 5, 2019
5a25bb6
Merge branch 'feat/throw-no-file' of https://github.com/whitecrownclo…
Aug 5, 2019
5be4fd9
Don't throw when not matching with glob pattern
Aug 5, 2019
ad3b19e
Merge branch 'master' into feat/throw-no-file
whitecrownclown Aug 5, 2019
9c9606a
Add mixed path and glob test
Aug 11, 2019
8f0c3d0
Throw on missing mixed path and glob; Update tests
Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,7 @@ module.exports = (source, destination, options = {}) => {
}

if (files.length === 0) {
progressEmitter.emit('progress', {
totalFiles: 0,
percent: 1,
completedFiles: 0,
completedSize: 0
});
throw new CpyError(`Cannot copy \`${source}\`: no files found`);
whitecrownclown marked this conversation as resolved.
Show resolved Hide resolved
}

const fileProgressHandler = event => {
Expand Down
16 changes: 3 additions & 13 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,21 +135,11 @@ test('glob errors are CpyErrors', async t => {
t.true(error instanceof CpyError);
});

test('reports copy progress of no files', async t => {
test('throws on non-existing file', async t => {
fs.mkdirSync(t.context.tmp);
fs.mkdirSync(path.join(t.context.tmp, 'cwd'));

let report;
await cpy('*', t.context.tmp, {cwd: path.join(t.context.tmp, 'cwd')})
.on('progress', event => {
report = event;
});

t.not(report, undefined);
t.is(report.totalFiles, 0);
t.is(report.completedFiles, 0);
t.is(report.completedSize, 0);
t.is(report.percent, 1);
const error = await t.throwsAsync(cpy(['no-file'], t.context.tmp));
whitecrownclown marked this conversation as resolved.
Show resolved Hide resolved
t.true(error instanceof CpyError);
});

test('reports copy progress of single file', async t => {
Expand Down