This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Feature/contributor page #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward port sitrunlab#69 * master: added entity test fixes exclude the vendor folder from coverage because of wrong jumping folder added vendor/ to blacklist coverage added IF NOT EXISTS check configure travis to fit with database sitrunlab#69 changelog added sqldump - remove unused static config config/autoload/global.php for module list - Apply fetch module from the module_list table load module list from db in home page initial db usage for module list
Forward port sitrunlab#70 * master: (34 commits) Added vendor directory to test code coverage blacklist in Pagination module Fixed code sniffer errors Fixed wrong return types Added documentation for Pagination module Added IndexControllerTest in Pagination module Added QueryUrlFactoryTest in Pagination module Added IndexControllerFactoryTest in Pagination module Created first tests for Pagination module Paginator view partial now uses queryUrl helper in Pagination module Fixed bugs on QueryUrl view helper in Pagination module Created QueryUrl view helper to allow query params inheritance in Pagination module Added message in Pagination module which is displayed when no elements are returned Created filtering form in Pagination module Added Pagination module to build script Enhanced data rendering in Pagination module Implemented rendering of data table in Pagination module Created pagination partial Implemented data manipulation in Pagination module Created Pagination\IndexControllerFactory Created data array for Pagination module ...
Forward port sitrunlab#71 * master: update sqldump as new Pagination module
|
"again" I forgot to change the destination to develop.. sorry |
|
Thank you. it is targetted to 0.0.3 which is maintenance release, so it is right to master, this just need to rebase. I will cherry-pick mockiemockiz@94b3f43 to my branch. the commit will grabbed, but will not looks merged because I only 'grab' one commit from this PR, the first 2 commits on this PR is not related to this PR. On future PR, the PR should rebase first, like : master and develop should only changed by |
|
I've cherry-picked mockiemockiz@94b3f43 into PR #74 , Thank you ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributor page would be look like this:
but it would be better to remake the icons so the icon looks fit like other, but I'm using ubuntu now and I don't like the gimp. maybe later I'll remake them.