contributors page #74
Conversation
|
update : |
samsonasik
force-pushed
the
contributor-page
branch
from
bddb899 to
8ecb5c2
Compare
|
Awesome! Looks really good. |
|
thanks, not sure about testing consolecontroller as testing access make call to github api make limited access. ready for review ;) |
|
Maybe the http client or at least the adapter should be injected. We could Alejandro Celaya Alastrué
|
|
Yes, I will try to inject the adapter. oh, yes, there is Test adapter, I will try it. |
|
I've added test for ConsoleController using Test Adapter. not 100% tested for now but I think it is ok for now ;) |
|
I like how it looks now. |
* contributor-page: #74 : add note to CHANGELOG.md add assertion added test for consolecontroller patch on dispatch for layout choose inject the controller with Http Client fixes cs update .phpcs fixes travis build make $contributors pass to ContributorsController fix forgotten 2columns layout fix page update fixes cs patch cs remove left bar for contribution page using "skipWelcome" layout variable using Zend navigation to build nav menu added navigation added test for contributors page fixes cs contributor page
Forward port #74 * master: #74 : add note to CHANGELOG.md add assertion added test for consolecontroller patch on dispatch for layout choose inject the controller with Http Client fixes cs update .phpcs fixes travis build make $contributors pass to ContributorsController fix forgotten 2columns layout fix page update fixes cs patch cs remove left bar for contribution page using "skipWelcome" layout variable using Zend navigation to build nav menu added navigation added test for contributors page fixes cs contributor page
|
@mockiemockiz thanks for the design It's merged to master : 3ca63bf Awesome. It's online now : http://learnzf2.sitrun-tech.com/contributors ;) |
No description provided.