Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI maintinence and more clang-tidy checks #66

Merged
merged 6 commits into from
Apr 13, 2024
Merged

CI maintinence and more clang-tidy checks #66

merged 6 commits into from
Apr 13, 2024

Conversation

JJL772
Copy link
Member

@JJL772 JJL772 commented Apr 12, 2024 •
edited
Loading

  • CI Improvements
    • Upgrade to Ubuntu 22.04 (Now using gcc 11, clang 14)
    • Fix bear usage in CI
    • Enable TIRPC for asyn in CI for Linux
    • Annotate the workflow yaml file
  • clang-tidy improvements
    • Switch to new list syntax in .clang-tidy
    • Enable more checks and explain why they're enabled
  • Update .editorconfig

JJL772 added 3 commits April 11, 2024 17:00
@JJL772
MNT: Upgrade to Ubuntu 22.04, annotate CI yaml
b4dfe06
@JJL772
MNT: 2 space idents for clang configs please
5d8be43
@JJL772
ENH: Expand list of clang-tidy checks and use new list syntax
0250553 
Bunch of new clang-tidy checks, mostly a subset of bugprone- and misc-.
Also added annotations explaining why these are necessary.

.clang-tidy now supports a list syntax in clang 17. To retain backwards
compatibility with older versions of clang-tidy, the script will
automatically convert the config to a JSON and passes that to clang-tidy
directly.
@JJL772 JJL772 marked this pull request as ready for review April 12, 2024 01:52
marciodo
marciodo approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@marciodo marciodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see anything obviously wrong with the changes.

@JJL772 JJL772 merged commit 8f8a6d2 into slac-epics:pre-release Apr 13, 2024
11 checks passed
@JJL772 JJL772 deleted the mnt_ci_upgrades branch April 13, 2024 03:02
@JJL772 JJL772 mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marciodo marciodo marciodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JJL772 @marciodo