Fix #632 Change the default settings to "useRtmConnect: true" #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #633 +/- ##
=======================================
Coverage 83.82% 83.82%
=======================================
Files 6 6
Lines 408 408
Branches 91 91
=======================================
Hits 342 342
Misses 38 38
Partials 28 28 Continue to review full report at Codecov.
|
seratch
commented
Nov 24, 2021
| # https://api.slack.com/changelog/2021-10-rtm-start-to-stop | ||
| options.rtm.useRtmConnect = true | ||
| catch e | ||
| console.error(e) |
There was a problem hiding this comment.
Just for better developer experience. The code has been silently ignoring the exception raised here.
| @@ -9,9 +9,18 @@ exports.use = (robot) -> | |||
| # reacts to only messages by insalled workspace users in a shared channel | |||
| installedTeamOnly: process.env.INSTALLED_TEAM_ONLY? | |||
| try | |||
| options.rtm = JSON.parse(process.env.HUBOT_SLACK_RTM_CLIENT_OPTS) | |||
| catch | |||
| options.rtm = JSON.parse(process.env.HUBOT_SLACK_RTM_CLIENT_OPTS or '{}') | |||
There was a problem hiding this comment.
If you set the env variable to an empty string, the parsing fails. This change improves the behavior in the scenario.
|
I've verified the behavior with an example Hubot app. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #632 -- refer to the issue for the context
Requirements (place an
xin each[ ])