Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #632 Change the default settings to "useRtmConnect: true" #633

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fix #632 Change the default settings to "useRtmConnect: true" #633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions slack.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,18 @@ exports.use = (robot) ->
# reacts to only messages by insalled workspace users in a shared channel
installedTeamOnly: process.env.INSTALLED_TEAM_ONLY?
try
options.rtm = JSON.parse(process.env.HUBOT_SLACK_RTM_CLIENT_OPTS)
catch
options.rtm = JSON.parse(process.env.HUBOT_SLACK_RTM_CLIENT_OPTS or '{}')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you set the env variable to an empty string, the parsing fails. This change improves the behavior in the scenario.

unless options.rtm.useRtmConnect?
# The original way to connect to one of our oldest APIs is finally retiring.
# For existing apps, rtm.start will start behaving exactly like rtm.connect
# on September 20, 2022. Beginning November 30, 2021, newly created apps and integrations
# will only be able to use rtm.connect.
# https://api.slack.com/changelog/2021-10-rtm-start-to-stop
options.rtm.useRtmConnect = true
catch e
console.error(e)
Copy link
Member Author

@seratch seratch Nov 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for better developer experience. The code has been silently ignoring the exception raised here.

try
options.rtmStart = JSON.parse(process.env.HUBOT_SLACK_RTM_START_OPTS)
catch
options.rtmStart = JSON.parse(process.env.HUBOT_SLACK_RTM_START_OPTS or '{}')
catch e
console.error(e)
new SlackBot robot, options