Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-vitess-r15.0.5:cherrypick rdonly patch (#77) #298

Merged
merged 1 commit into from
Apr 16, 2024
Merged

slack-vitess-r15.0.5:cherrypick rdonly patch (#77) #298

merged 1 commit into from
Apr 16, 2024

Conversation

timvaillancourt
Copy link
Member

Description

This PR cherry-picks #77 to the v15 branch 😢

Related Issue(s)

#77

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@tanjinx @timvaillancourt
slack-vitess-r14.0.5:cherrypick: backport rdonly patch (#77)
9d4ffe7 
* backport pr 29

* fix missing variable

* fix missing patch

* update help text
@timvaillancourt timvaillancourt requested a review from a team as a code owner April 12, 2024 18:07
@github-actions github-actions bot added this to the v15.0.5 milestone Apr 12, 2024
@timvaillancourt timvaillancourt merged commit 83ce817 into slack-vitess-r15.0.5 Apr 16, 2024
196 checks passed
@timvaillancourt timvaillancourt deleted the slackhq-pr77-slack-vitess-r15.0.5 branch April 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roderickyao roderickyao roderickyao approved these changes

@vmogilev vmogilev vmogilev approved these changes

Assignees
No one assigned
Labels
custom-patch slack-cherrypick v15
Projects
None yet
Milestone
v15.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@timvaillancourt @vmogilev @roderickyao @tanjinx