Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-vitess-r14.0.5:cherrypick: backport rdonly patch #77

Merged
merged 4 commits into from
May 9, 2023
Merged

slack-vitess-r14.0.5:cherrypick: backport rdonly patch #77

merged 4 commits into from
May 9, 2023

Conversation

tanjinx
Copy link

@tanjinx tanjinx commented May 8, 2023 •
edited
Loading

Description

backport tabletgateway-related PRs:
https://github.com/slackhq/vitess/pull/18/files
https://github.com/slackhq/vitess/pull/29/files

wget https://github.com/slackhq/vitess/pull/18.patch
git apply -v ~/18.patch
wget https://github.com/slackhq/vitess/pull/29.patch
git apply -v ~/29.patch

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@tanjinx tanjinx requested a review from a team as a code owner May 8, 2023 23:51
@tanjinx tanjinx changed the title Backport rdonly patch slack-vitess-r14.0.5:cherrypick: backport rdonly patch May 8, 2023
@tanjinx tanjinx merged commit 2987323 into slack-vitess-r14.0.5 May 9, 2023
@tanjinx tanjinx added the upstream-backport An upstream backport label Feb 22, 2024
@timvaillancourt timvaillancourt deleted the backport-rdonly-patch branch April 12, 2024 18:02
timvaillancourt pushed a commit that referenced this pull request Apr 12, 2024
@tanjinx @timvaillancourt
slack-vitess-r14.0.5:cherrypick: backport rdonly patch (#77)
9d4ffe7 
* backport pr 29

* fix missing variable

* fix missing patch

* update help text
@timvaillancourt timvaillancourt mentioned this pull request Apr 12, 2024
Merged
4 tasks
timvaillancourt added a commit that referenced this pull request Apr 16, 2024
@timvaillancourt @tanjinx
slack-vitess-r14.0.5:cherrypick: backport rdonly patch (#77) (#298)
83ce817 
* backport pr 29

* fix missing variable

* fix missing patch

* update help text

Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbibra pbibra pbibra approved these changes

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt

@vmogilev vmogilev Awaiting requested review from vmogilev

Assignees
No one assigned
Labels
slack-cherrypick tabletgateway upstream-backport An upstream backport v14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanjinx @pbibra