Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added search engine toggle #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

humantorch
Copy link

I added a radio button to allow the user to choose between Google and DuckDuckGo. Feel free to merge into yours if you want!

@peterberbec
Copy link
Contributor

Did you manage to incorporate filetype:html, !safeoff as well as !ducky into duck duck go? I was failing. :(

@slifty
Copy link
Owner

slifty commented Mar 30, 2017

@peterberbec what does !safeoff do in this context? (I want to be careful not to disable NSFW filters when they do exist, since I'm sure people are using it at work occasionally)

@humantorch thank you for the PR! My only concern is that any type of choice might break the simplicity -- I'm thinking it might be good to have an "advanced settings" area in a hidden location for power users (and make it possible to set settings via querystring).

If you don't mind I might try to incorporate your button into that kind of interface.

Regardless, I'd love to have duckduckgo simply be the default for everyone.

@peterberbec
Copy link
Contributor

@slifty !safeoff does exactly that, disables nsfw filtering. Issue I had when I played with DDG was it was stall the page if it encountered a safe page

@humantorch
Copy link
Author

humantorch commented Mar 30, 2017

@peterberbec No, all I did was prepend the search terms with a \ character which invokes DDG's version of I Feel Lucky (which I didn't realise was a Thing until I found this page: http://rumyittips.com/search-smarter-than-google-with-duckduckgo – point 9).

@slifty No worries at all, feel free to use anything I added as you see fit. Your point about not wanting to over-complicate things is totally valid. I'd originally just swapped in DDG for Google and it worked fine, and then thought "what the hoo-ha might as well make it a choice" so it's not like I'd spent hours agonising over the UI. ;)

@ElonSatoshi
Copy link

@slifty It's been 3 years since this project has seen any commits, and I see there's some really neat pull requests. I'd love to see some customization added to it. I'm going to start using this! I really like that it's just an html file, so all you need to run it is a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants