-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query string parsing for engine and number of tabs #25
base: master
Are you sure you want to change the base?
Conversation
Awesome! The optional stuff is a little bit in the "power user" territory (some of the appeal of this to non-techies is that it's just a simple button) -- any chance it could be wrapped in an "advanced" section at the bottom of the page (e.g. an "advanced options" link that would .show() the form you created) One key point: these options are secondary in importance to the "suggested steps" listed under the -- it is important as many people as possible see those steps. Regardless of whether they are wrapped in an advanced options toggle, they should probably appear under another below the suggested steps. |
(Also, it looks like there are some conflicts in this branch, please resolve those if possible) |
Accidentally created a pr to fix #17 before addressing your suggestions. I'll make them now. |
@slifty: all fixed. |
Based on suggestions left in the comments of #15