Improve docs for slog::Value trait
#336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Techcable
commented
Sep 23, 2024
Techcable
commented
- Typo: The phrase "implement this type" should be "implement this trait" -- Thanks to @larswirzenius for noticing this
- Fixes issue slog::Value doc says "Types that implement this type", should say "this trait_ #335
- Style: Avoid using the word "implement" twice in a row
Techcable
force-pushed
the
typo/slog-value-issue335
branch
from
683b3f4 to
3743e8a
Compare
Thank you for @larswirzenius for noticing this! Fixes slog-rs#335
This is a minor style improvement, not even worthy of comment in CHANGELOG.
Techcable
force-pushed
the
typo/slog-value-issue335
branch
from
3743e8a to
4524d0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.