Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for slog::Value trait #336

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Improve docs for slog::Value trait #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dbf5b3
doc: Fix typo in slog::Value docs (issue #335)
Techcable Sep 23, 2024
4524d0a
doc: Avoid using 'implement' twice in slog::Value
Techcable Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
* doc: Fix typo in slog::Value docs (issue #335)
* Thank you to @larswirzenius for noticing this!
* doc: Fix "lazy continuation" in `slog::Logger` doc
* This mistake was caught by a new lint [`#[warn(clippy::doc_lazy_continuation)]`](https://rust-lang.github.io/rust-clippy/rust-1.81.0/index.html#/doc_lazy_continuation)
* Fix some internal warnings
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2953,7 +2953,7 @@ where
// {{{ Value
/// Value that can be serialized
///
/// Types that implement this type implement custom serialization in the
/// Types that implement this trait have custom serialization in the
/// structured part of the log macros. Without an implementation of `Value` for
/// your type you must emit using either the `?` "debug", `#?` "pretty-debug",
/// `%` "display", `#%` "alternate display" or [`SerdeValue`](trait.SerdeValue.html)
Expand Down
Loading