Introduce unknown address type. #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
requested review from
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
winder
force-pushed
the
will/unknown-address
branch
from
9ff4596
to
f817197
Compare
mateusz-sekara
approved these changes
Oct 22, 2024
| @@ -31,7 +31,7 @@ jobs: | |||
| with: | |||
| repository: smartcontractkit/chainlink | |||
| # ref: develop | |||
| ref: fix-fee-quoter | |||
There was a problem hiding this comment.
How about making it work as a manual trigger as well? I mean overriding this value with every PR is very error prone. Maybe ability to trigger the job from GHA with custom branch from chainlink would be sufficient just to run these tests before merging? cc @b-gopalswami
There was a problem hiding this comment.
Yeah, I pitched this idea before and received some pushback. I'm not against it, it should be straightforward as a flow:
- comment on the pull request "cmd branch " to on demand run the test using the appropriate chainlink branch
- some sort of trigger on comment with github actions. Parse the comment and ensure it comes from PR author, etc. then trigger the workflow with the branch name
makramkd
approved these changes
Oct 22, 2024
|
Please make sure to revert back to |
winder
force-pushed
the
will/unknown-address
branch
from
f817197
to
dfbaf57
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the many account types (string, []byte, types.Account) with
UnknownAddressandUnknownEncodedAddress. These types are now used across the CCIP code and can extended in the future to add chain agnostic encoding and validation functions.Related chainlink changes: