Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccip: use unknown address type. #14836

Merged
merged 4 commits into from
Oct 23, 2024
Merged

ccip: use unknown address type. #14836

merged 4 commits into from
Oct 23, 2024

Conversation

winder
Copy link
Contributor

@winder winder commented Oct 17, 2024 •
edited
Loading

Update ccip capability to use the unknown address type introduced with smartcontractkit/chainlink-ccip#248

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@winder winder mentioned this pull request Oct 17, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@winder winder force-pushed the will/unknown-address branch 2 times, most recently from bfad239 to bb5b0e1 Compare October 21, 2024 19:35
@winder winder changed the base branch from develop to fix-fee-quoter October 21, 2024 19:51
Base automatically changed from fix-fee-quoter to develop October 22, 2024 18:16
@winder winder marked this pull request as ready for review October 22, 2024 18:39
@winder winder requested review from a team as code owners October 22, 2024 18:39
chainchad
chainchad reviewed Oct 22, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
asoliman92
asoliman92 previously approved these changes Oct 22, 2024
View reviewed changes
asoliman92
asoliman92 previously approved these changes Oct 22, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
3 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@winder winder enabled auto-merge October 23, 2024 12:01
@winder winder added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit 6ba13c7 Oct 23, 2024
146 of 148 checks passed
@winder winder deleted the will/unknown-address branch October 23, 2024 12:42
momentmaker added a commit that referenced this pull request Oct 23, 2024
@momentmaker
Merge branch 'develop' into re-3123/add-changesetKey-check
5750274 
* develop:
  rm gethwrappers from codeowners offchain (#14919)
  CCIP-3899 fix sender encoding (#14877)
  ccip: use unknown address type. (#14836)
  [chore] Add changeset entry for RequestRoundTracker fix (#14912)
  various Solidity Foundry updates (#14866)
  CCIP-3710 create new custom calldata L1 (DA) gas oracle (#14710)
  CCIP owns smoke test (#14906)
  core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861)
  CCIP-3730 Misc ccip onchain changes (#14845)
  Chain fee integration tests (#14829)
  release/2.17.0 -> develop (#14721)
  Solana: re-enable disabled test with updated version (#14892)
cedric-cordenier pushed a commit that referenced this pull request Oct 24, 2024
@winder @cedric-cordenier
ccip: use unknown address type. (#14836)
5ee611a 
* Use new address type.

gomodtidy

* Use main branch

* Fix weth symbol

* errors
@chainchad chainchad mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad left review comments

@gheorghestrimtu gheorghestrimtu gheorghestrimtu approved these changes

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@dimkouv dimkouv dimkouv approved these changes

@kalverra kalverra kalverra approved these changes

@jmank88 jmank88 jmank88 approved these changes

@asoliman92 asoliman92 asoliman92 left review comments

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner automatically assigned from smartcontractkit/foundations

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@winder @jmank88 @asoliman92 @kalverra @dimkouv @mateusz-sekara @gheorghestrimtu @chainchad