Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCFR-967 - Basic support for method writing and reading - Add logic to enable/disable test cases for chain components common test suite #829

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

BCFR-967 - Basic support for method writing and reading - Add logic to enable/disable test cases for chain components common test suite #829

wants to merge 3 commits into from
+192 −120

Conversation

pablolagreca
Copy link

@pablolagreca pablolagreca commented Oct 3, 2024 •
edited
Loading

As part of adding basic support for generating EVM bindings for CR/CW for solidity contracts we add functionality to be able to disable test cases not yet supported by a partial implementation so we can commit incremental changes without having full support from day one.

solana ref: BCFR-966

@pablolagreca pablolagreca requested review from a team and nolag as code owners October 3, 2024 12:52
@pablolagreca pablolagreca requested review from george-dorin and removed request for a team October 3, 2024 12:52
Farber98
Farber98 previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@Farber98 Farber98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see this really useful!

@pablolagreca pablolagreca mentioned this pull request Oct 3, 2024
Open
ilija42
ilija42 reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the approach looks fine, can you modfiy the EVM or Solana tests to use this?
EDIT: Just saw that there is a Solana PR, just added it to the description

ilija42
ilija42 requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't enabledTests be exported so that the relayers can have a list of enabled tests?

ilija42
ilija42 reviewed Oct 7, 2024
View reviewed changes
pkg/types/interfacetests/utils.go Outdated
name string
test func(t T)
type TestSelectionSupport struct {
enabledTests map[string]bool
Copy link
Contributor

@ilija42 ilija42 Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe its more intuitive if we call this disabledTests, since the default state is enabled?

@aalu1418 aalu1418 mentioned this pull request Oct 31, 2024
Open
ilija42
ilija42 previously approved these changes Oct 31, 2024
View reviewed changes
Farber98
Farber98 previously approved these changes Oct 31, 2024
View reviewed changes
Pablo La Greca and others added 2 commits November 5, 2024 15:32
@pablolagreca pablolagreca dismissed stale reviews from ilija42 and Farber98 via add2419 November 5, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 approved these changes

@Farber98 Farber98 Farber98 approved these changes

@jmank88 jmank88 jmank88 approved these changes

@nolag nolag Awaiting requested review from nolag nolag is a code owner

@george-dorin george-dorin Awaiting requested review from george-dorin george-dorin is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablolagreca @jmank88 @Farber98 @ilija42