Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCFR-967 - EVM Chain bindings for CR/CW - Basic support for method #14657

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

BCFR-967 - EVM Chain bindings for CR/CW - Basic support for method #14657

wants to merge 2 commits into from
+1,221 −298

Conversation

pablolagreca
Copy link
Collaborator

@pablolagreca pablolagreca commented Oct 3, 2024 •
edited by jira bot
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

WF: CI Core#b52969b

No errors found in this run. 🎉

@pablolagreca pablolagreca force-pushed the BCFR-967 branch 2 times, most recently from 2135575 to b52969b Compare October 15, 2024 11:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

WF: CI Core#9b1db39

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

WF: CI Core#5aec27f

No errors found in this run. 🎉

@pablolagreca pablolagreca force-pushed the BCFR-967 branch 2 times, most recently from 5aec27f to 1930aee Compare October 15, 2024 14:10
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Find New Flaky Tests In Root Project / Find Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , lint , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Deployment Project , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/relay/evm) , Find New Flaky Tests In Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Error parsing JSON test output: [Find New Flaky Tests In Root Project / Run Tests]

Source of Error: 
Run tests with flakeguard	2024-11-07T17:55:52.0155522Z Error running tests: failed to parse json test output: # github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/evmtesting [github.com/smartcontractkit/chainlink/v2/core/services/relay/evm.test], err: invalid character '#' looking for beginning of value
Run tests with flakeguard	2024-11-07T17:55:52.0174558Z ##[error]Process completed with exit code 1.
**Why**: The test output contains an invalid character '#' which causes the JSON parser to fail.

Suggested fix: Ensure that the test output is properly formatted as JSON. Remove or escape any invalid characters before parsing.

2. Undefined TestSelectionSupport: [Golang Lint]

Source of Error: 
Golang Lint	2024-11-07T17:53:10.7237871Z # github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/evmtesting
Golang Lint	2024-11-07T17:53:10.7305904Z ##[error]core/services/relay/evm/evmtesting/chain_components_interface_tester.go:63:2: undefined: TestSelectionSupport
**Why**: The `TestSelectionSupport` identifier is not defined in the scope where it is being used.

Suggested fix: Define TestSelectionSupport or ensure it is imported correctly if it is part of another package.

3. Undefined fields and methods in bindings_test_adapter.go: [Golang Lint]

Source of Error: 
Golang Lint	2024-11-07T17:53:10.7309875Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:29:10: wrapped.DisableTests undefined (type *EVMChainComponentsInterfaceTester[*"testing".T] has no field or method DisableTests)
Golang Lint	2024-11-07T17:53:10.7313186Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:30:18: undefined: interfacetests.ContractReaderGetLatestValueAsValuesDotValue
Golang Lint	2024-11-07T17:53:10.7377175Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:30:79: undefined: interfacetests.ContractReaderGetLatestValueNoArgumentsAndPrimitiveReturnAsValuesDotValue
Golang Lint	2024-11-07T17:53:10.7381420Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:30:169: undefined: interfacetests.ContractReaderGetLatestValueNoArgumentsAndSliceReturnAsValueDotValue
Golang Lint	2024-11-07T17:53:10.7384638Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:31:18: undefined: interfacetests.ContractReaderGetLatestValueGetsLatestForEvent
Golang Lint	2024-11-07T17:53:10.7388166Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:31:81: undefined: interfacetests.ContractReaderGetLatestValueBasedOnConfidenceLevelForEvent
Golang Lint	2024-11-07T17:53:10.7391729Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:18: undefined: interfacetests.ContractReaderGetLatestValueReturnsNotFoundWhenNotTriggeredForEvent
Golang Lint	2024-11-07T17:53:10.7395510Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:102: undefined: interfacetests.ContractReaderGetLatestValueWithFilteringForEvent
Golang Lint	2024-11-07T17:53:10.7398475Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:168: undefined: interfacetests.ContractReaderBatchGetLatestValue
Golang Lint	2024-11-07T17:53:10.7400864Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:168: too many errors
**Why**: The `DisableTests` method and several fields from `interfacetests` are not defined or imported correctly.

Suggested fix: Ensure that the DisableTests method and the fields from interfacetests are defined and imported correctly. Verify the correct package and method names.

4. Missing executable file evm-chain-bindings: [Clean Go Tidy & Generate]

Source of Error: 
make generate	2024-11-07T17:56:14.3225304Z 	core/services/relay/evm/chain_components_test.go:209: running "evm-chain-bindings": exec: "evm-chain-bindings": executable file not found in /snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
**Why**: The `evm-chain-bindings` executable is not found in the specified paths.

Suggested fix: Ensure that the evm-chain-bindings executable is installed and available in the system's PATH. Add the directory containing evm-chain-bindings to the PATH environment variable if necessary.

5. Build failed due to undefined identifiers: [Core Tests (go_core_fuzz)]

Source of Error: 
Run tests	2024-11-07T17:57:09.3303433Z # github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/evmtesting
Run tests	2024-11-07T17:57:09.3353651Z ##[error]core/services/relay/evm/evmtesting/chain_components_interface_tester.go:63:2: undefined: TestSelectionSupport
Run tests	2024-11-07T17:57:09.3362592Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:29:10: wrapped.DisableTests undefined (type *EVMChainComponentsInterfaceTester[*"testing".T] has no field or method DisableTests)
Run tests	2024-11-07T17:57:09.3365882Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:30:18: undefined: interfacetests.ContractReaderGetLatestValueAsValuesDotValue
Run tests	2024-11-07T17:57:09.3368909Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:30:79: undefined: interfacetests.ContractReaderGetLatestValueNoArgumentsAndPrimitiveReturnAsValuesDotValue
Run tests	2024-11-07T17:57:09.3372012Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:30:169: undefined: interfacetests.ContractReaderGetLatestValueNoArgumentsAndSliceReturnAsValueDotValue
Run tests	2024-11-07T17:57:09.3374704Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:31:18: undefined: interfacetests.ContractReaderGetLatestValueGetsLatestForEvent
Run tests	2024-11-07T17:57:09.3377512Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:31:81: undefined: interfacetests.ContractReaderGetLatestValueBasedOnConfidenceLevelForEvent
Run tests	2024-11-07T17:57:09.3380508Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:18: undefined: interfacetests.ContractReaderGetLatestValueReturnsNotFoundWhenNotTriggeredForEvent
Run tests	2024-11-07T17:57:09.3385951Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:102: undefined: interfacetests.ContractReaderGetLatestValueWithFilteringForEvent
Run tests	2024-11-07T17:57:09.3390200Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:168: undefined: interfacetests.ContractReaderBatchGetLatestValue
Run tests	2024-11-07T17:57:09.3393846Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:168: too many errors
**Why**: The same undefined identifiers and methods as in the Golang Lint job are causing the build to fail.

Suggested fix: Ensure that the DisableTests method and the fields from interfacetests are defined and imported correctly. Verify the correct package and method names.

6. Build failed due to undefined identifiers: [Core Tests (go_core_tests)]

Source of Error: 
Run tests	2024-11-07T17:55:57.5724094Z # github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/evmtesting [github.com/smartcontractkit/chainlink/v2/core/services/relay/evm.test]
Run tests	2024-11-07T17:55:57.5799232Z ##[error]core/services/relay/evm/evmtesting/chain_components_interface_tester.go:63:2: undefined: TestSelectionSupport
Run tests	2024-11-07T17:55:57.5814220Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:29:10: wrapped.DisableTests undefined (type *EVMChainComponentsInterfaceTester[*"testing".T] has no field or method DisableTests)
Run tests	2024-11-07T17:55:57.5819393Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:30:18: undefined: interfacetests.ContractReaderGetLatestValueAsValuesDotValue
Run tests	2024-11-07T17:55:57.5824394Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:30:79: undefined: interfacetests.ContractReaderGetLatestValueNoArgumentsAndPrimitiveReturnAsValuesDotValue
Run tests	2024-11-07T17:55:57.5829712Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:30:169: undefined: interfacetests.ContractReaderGetLatestValueNoArgumentsAndSliceReturnAsValueDotValue
Run tests	2024-11-07T17:55:57.5834455Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:31:18: undefined: interfacetests.ContractReaderGetLatestValueGetsLatestForEvent
Run tests	2024-11-07T17:55:57.5839135Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:31:81: undefined: interfacetests.ContractReaderGetLatestValueBasedOnConfidenceLevelForEvent
Run tests	2024-11-07T17:55:57.5844468Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:18: undefined: interfacetests.ContractReaderGetLatestValueReturnsNotFoundWhenNotTriggeredForEvent
Run tests	2024-11-07T17:55:57.5849123Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:102: undefined: interfacetests.ContractReaderGetLatestValueWithFilteringForEvent
Run tests	2024-11-07T17:55:57.5853434Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:168: undefined: interfacetests.ContractReaderBatchGetLatestValue
Run tests	2024-11-07T17:55:57.5857270Z ##[error]core/services/relay/evm/evmtesting/bindings_test_adapter.go:32:168: too many errors
**Why**: The same undefined identifiers and methods as in the Golang Lint job are causing the build to fail.

Suggested fix: Ensure that the DisableTests method and the fields from interfacetests are defined and imported correctly. Verify the correct package and method names.

AER Report: Operator UI CI

aer_workflow , commit , Breaking Changes GQL Check

1. Workflow failed to complete successfully:[convictional/trigger-workflow-and-wait@f69fa9e]

Source of Error: 
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-07T17:49:54.5639332Z Checking conclusion [failure]
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-07T17:49:54.5640332Z Checking status [completed]
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-07T17:49:54.5641383Z Conclusion is not success, it's [failure].
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-07T17:49:54.5642586Z Propagating failure to upstream job

Why: The triggered workflow did not complete successfully. The status was checked multiple times and eventually concluded with a failure status.

Suggested fix: Investigate the logs of the triggered workflow (https://github.com/smartcontractkit/operator-ui/actions/runs/11728486117) to identify the specific cause of failure and address it.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
3 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
95.6% Coverage on New Code
6.7% Duplication on New Code

See analysis details on SonarQube

@pablolagreca pablolagreca marked this pull request as ready for review October 30, 2024 21:17
@pablolagreca pablolagreca requested review from a team as code owners October 30, 2024 21:17
ilija42
ilija42 previously approved these changes Oct 31, 2024
View reviewed changes
jmank88
jmank88 reviewed Nov 4, 2024
View reviewed changes
core/services/relay/evm/evmtesting/run_tests.go Outdated
Comment on lines 25 to 32
QueryKeyFilterOnDataWordsWithValueComparator = "Filtering can be done on data words using value comparator"
QueryKeyOnDataWordsWithValueComparatorOnNestedField = "Filtering can be done on data words using value comparator on a nested field"
QueryKeyFilterOnDataWordsWithValueComparatorOnDynamicField = "Filtering can be done on data words using value comparator on field that follows a dynamic field"
QueryKeyFilteringOnDataWordsUsingValueComparatorsOnFieldsWithManualIndex = "Filtering can be done on data words using value comparators on fields that require manual index input"
DynamicTypedTopicsFilterAndCorrectReturn = "Dynamically typed topics can be used to filter and have type correct in return"
MultipleTopicCanFilterTogether = "Multiple topics can filter together"
FilteringCanBeDoneOnHashedIndexedTopics = "Filtering can be done on indexed topics that get hashed"
BindReturnsErrorOnMissingContractAtAddress = "Bind returns error on missing contract at address"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This names are pretty hard to read. What is the advantage of using constants over inline literals?

@pablolagreca pablolagreca force-pushed the BCFR-967 branch 3 times, most recently from 1b64f68 to 9340608 Compare November 6, 2024 20:30
@pablolagreca pablolagreca force-pushed the BCFR-967 branch 2 times, most recently from 0440d26 to 84469be Compare November 7, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 left review comments

@Atrax1 Atrax1 Awaiting requested review from Atrax1 Atrax1 is a code owner automatically assigned from smartcontractkit/foundations

@jmank88 jmank88 Awaiting requested review from jmank88

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablolagreca @jmank88 @ilija42