Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCFR-887 Use tx in insertLogsWithinTx #14361

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

dhaidashenko
Copy link
Collaborator

No description provided.

@dhaidashenko dhaidashenko marked this pull request as ready for review September 6, 2024 16:41
@dhaidashenko dhaidashenko requested review from a team as code owners September 6, 2024 16:41
@dhaidashenko dhaidashenko requested review from george-dorin and removed request for a team September 6, 2024 16:41
@dhaidashenko dhaidashenko changed the title Use tx in insertLogsWithinTx BCFR-887 Use tx in insertLogsWithinTx Sep 6, 2024
Copy link
Contributor

@reductionista reductionista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dimriou dimriou added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@dimriou dimriou added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@dimriou dimriou added this pull request to the merge queue Sep 19, 2024
Merged via the queue into develop with commit 3a89dce Sep 19, 2024
136 of 137 checks passed
@dimriou dimriou deleted the fix/BCFR-887-insert-logs-with-block-atomic branch September 19, 2024 17:27
momentmaker added a commit that referenced this pull request Sep 19, 2024
…tractkit/chainlink into re-2964/goreleaser-ccip

* 're-2964/goreleaser-ccip' of https://github.com/smartcontractkit/chainlink:
  Fix data race in TestLogPoller_Replay (#14431)
  Fix CCIP Load Test Faulty Fund Return (#14499)
  use tx in insertLogsWithinTx (#14361)
  Bring KMS client and multiclient over to chainlink (#14484)
  CCIP-3420: Fix IsRequestTriggeredWithinTimeframe (#1445) (#14498)
  [TT-1345] option to use predeployed contracts in OCR tests (#13758)
  CCIP-3428 Enabling ccip smoke test for testnet (#14452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants