-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCFR-887 Use tx in insertLogsWithinTx #14361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaidashenko
requested review from
george-dorin
and removed request for
a team
September 6, 2024 16:41
dhaidashenko
changed the title
Use tx in insertLogsWithinTx
BCFR-887 Use tx in insertLogsWithinTx
Sep 6, 2024
DylanTinianov
approved these changes
Sep 6, 2024
reductionista
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 19, 2024
Quality Gate passedIssues Measures |
momentmaker
added a commit
that referenced
this pull request
Sep 19, 2024
…tractkit/chainlink into re-2964/goreleaser-ccip * 're-2964/goreleaser-ccip' of https://github.com/smartcontractkit/chainlink: Fix data race in TestLogPoller_Replay (#14431) Fix CCIP Load Test Faulty Fund Return (#14499) use tx in insertLogsWithinTx (#14361) Bring KMS client and multiclient over to chainlink (#14484) CCIP-3420: Fix IsRequestTriggeredWithinTimeframe (#1445) (#14498) [TT-1345] option to use predeployed contracts in OCR tests (#13758) CCIP-3428 Enabling ccip smoke test for testnet (#14452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.