Bring KMS client and multiclient over to chainlink #14484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogtownsend
force-pushed
the
chore/move-multiclient-and-kmsclient-to-chainlink
branch
from
8e3dcdc to
ce17604
Compare
ogtownsend
force-pushed
the
chore/move-multiclient-and-kmsclient-to-chainlink
branch
from
31e2aa6 to
2381add
Compare
AnieeG
reviewed
Sep 18, 2024
AnieeG
previously approved these changes
Sep 18, 2024
connorwstein
previously approved these changes
Sep 18, 2024
…ithub.com:smartcontractkit/chainlink into chore/move-multiclient-and-kmsclient-to-chainlink
makramkd
reviewed
Sep 18, 2024
| @@ -406,7 +406,6 @@ func (h *homeChain) AddNodes( | |||
| p2pIDs [][32]byte, | |||
| capabilityIDs [][32]byte, | |||
| ) { | |||
| // Need to sort, otherwise _checkIsValidUniqueSubset onChain will fail | |||
| sortP2PIDS(p2pIDs) | |||
There was a problem hiding this comment.
Pretty sure this and the associated function def'n can be deleted, sorting is no longer a requirement
There was a problem hiding this comment.
Anyway, not required to do in this PR ;-)
There was a problem hiding this comment.
I think this whole directory could probably deleted no? Thats what I had in mind with CCIP-3049
There was a problem hiding this comment.
If these helpers aren't used anywhere and these tests are not needed, yes.
…ithub.com:smartcontractkit/chainlink into chore/move-multiclient-and-kmsclient-to-chainlink
…ithub.com:smartcontractkit/chainlink into chore/move-multiclient-and-kmsclient-to-chainlink
AnieeG
approved these changes
Sep 19, 2024
|
connorwstein
approved these changes
Sep 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
connorwstein
deleted the
chore/move-multiclient-and-kmsclient-to-chainlink
branch
momentmaker
added a commit
that referenced
this pull request
Sep 19, 2024
…tractkit/chainlink into re-2964/goreleaser-ccip * 're-2964/goreleaser-ccip' of https://github.com/smartcontractkit/chainlink: Fix data race in TestLogPoller_Replay (#14431) Fix CCIP Load Test Faulty Fund Return (#14499) use tx in insertLogsWithinTx (#14361) Bring KMS client and multiclient over to chainlink (#14484) CCIP-3420: Fix IsRequestTriggeredWithinTimeframe (#1445) (#14498) [TT-1345] option to use predeployed contracts in OCR tests (#13758) CCIP-3428 Enabling ccip smoke test for testnet (#14452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Resolves