Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-1693] try more universal Solidity scripts #14436

Merged
merged 33 commits into from
Sep 23, 2024
Merged

[TT-1693] try more universal Solidity scripts #14436

merged 33 commits into from
Sep 23, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Sep 16, 2024 •
edited
Loading

This PR does a couple of things:

  • it moves Solidity Review Artifacts pipeline to .github repository, so that it can be reused in other repositories - released as @validate-solidity-artifacts@0.1.0
  • it also moves bash scripts used by that pipeline
  • ...and even Jira scripts that are used for enforcing traceablity (Solidity Review Artifacts pipeline also requires them)
  • a couple of Github Actions were also moved

Sample execution for:

Tests:

  • artifact pipeline works for automation since v2.14.0
  • artifact pipeline works for CCIP since v2.14.0
  • artifact pipeline is still fault-tolerant
  • foundry pipeline works for new contracts
  • foundry pipeline works for modified contracts
  • use reusable Solidity Artifact Workflow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Static analysis results are available

Hey @Tofel, you can view Slither reports in the job summary here or download them as artifact here.

Please check them before merging and make sure you have addressed all issues.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@Tofel Tofel force-pushed the tt_1693_more_universal_artifacts_pipeline branch 17 times, most recently from 1c225bb to 3ce0c6d Compare September 17, 2024 12:22
@Tofel Tofel force-pushed the tt_1693_more_universal_artifacts_pipeline branch 4 times, most recently from 789ff78 to 393bc06 Compare September 19, 2024 14:04
@Tofel Tofel force-pushed the tt_1693_more_universal_artifacts_pipeline branch from 393bc06 to e3e4ac8 Compare September 19, 2024 14:18
@Tofel Tofel force-pushed the tt_1693_more_universal_artifacts_pipeline branch from 048561c to 902d420 Compare September 19, 2024 14:27
@Tofel Tofel marked this pull request as ready for review September 19, 2024 14:45
@Tofel Tofel requested review from a team, RensR, matYang, RayXpub and elatoskinas as code owners September 19, 2024 14:45
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

scheibinger
scheibinger approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@scheibinger scheibinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tofel Tofel enabled auto-merge September 23, 2024 12:41
@Tofel Tofel added this pull request to the merge queue Sep 23, 2024
Merged via the queue into develop with commit f74ac81 Sep 23, 2024
106 checks passed
@Tofel Tofel deleted the tt_1693_more_universal_artifacts_pipeline branch September 23, 2024 12:58
momentmaker added a commit that referenced this pull request Sep 24, 2024
@momentmaker
Merge remote-tracking branch 'origin/develop' into release-2.16.0-to-…
efcbd1a 
…develop

* origin/develop: (233 commits)
  update Smoke Test TestAutomationBasic to load pre-deployed contracts if given (#14537)
  CCIP-2881  USDC Reader integration tests  (#14516)
  [TT-1624] link PR to solidity review issue (#14521)
  Fix skipped notification in E2E test workflow (#14538)
  Add regression testing for pruning bug (#14454)
  Bump owner dep (#14531)
  Fix state view (#14532)
  Deployment tooling (#14533)
  CCIP 3388 - add offramp generation (#14526)
  CCIP-3416 paginate token admin registry get all tokens call (#14514)
  Change Polygon zkEVM to use FeeHistory estimator (#14161)
  [TT-1747] fix core changeset (#14524)
  TT-1459 Use CTF actions from .github repo (#14522)
  [TT-1693] try more universal Solidity scripts (#14436)
  Remove unused workflow for e2e tests (#14520)
  BCI-3668 Optimise HeadTracker's memory usage (#14130)
  BCFR-888 LP support chains that have not reached finality yet (#14366)
  support new heads polling over http rpc client (#14373)
  Bump CTF (#14518)
  TT-1550 Migrate remaining E2E workflows to the reusable workflow (#14403)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszcl lukaszcl lukaszcl approved these changes

@scheibinger scheibinger scheibinger approved these changes

@RensR RensR Awaiting requested review from RensR

@matYang matYang Awaiting requested review from matYang

@RayXpub RayXpub Awaiting requested review from RayXpub

@elatoskinas elatoskinas Awaiting requested review from elatoskinas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tofel @scheibinger @lukaszcl