LogPoller ORM: add regression testing for pruning of multichain nodes #14454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
archseer
previously approved these changes
Sep 17, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
reductionista
dismissed stale reviews from mateusz-sekara and archseer
via
45af65e
reductionista
force-pushed
the
fix/prune-expired-logs-query
branch
2 times, most recently
from
45af65e to
0a0e6fc
Compare
reductionista
changed the title
reductionista
force-pushed
the
fix/prune-expired-logs-query
branch
2 times, most recently
from
e9f9cb1 to
ba95e1b
Compare
reductionista
force-pushed
the
fix/prune-expired-logs-query
branch
from
ba95e1b to
4c2e18d
Compare
|
patrickhuie19
approved these changes
Sep 20, 2024
mateusz-sekara
approved these changes
Sep 24, 2024
momentmaker
added a commit
that referenced
this pull request
Sep 24, 2024
…develop * origin/develop: (233 commits) update Smoke Test TestAutomationBasic to load pre-deployed contracts if given (#14537) CCIP-2881 USDC Reader integration tests (#14516) [TT-1624] link PR to solidity review issue (#14521) Fix skipped notification in E2E test workflow (#14538) Add regression testing for pruning bug (#14454) Bump owner dep (#14531) Fix state view (#14532) Deployment tooling (#14533) CCIP 3388 - add offramp generation (#14526) CCIP-3416 paginate token admin registry get all tokens call (#14514) Change Polygon zkEVM to use FeeHistory estimator (#14161) [TT-1747] fix core changeset (#14524) TT-1459 Use CTF actions from .github repo (#14522) [TT-1693] try more universal Solidity scripts (#14436) Remove unused workflow for e2e tests (#14520) BCI-3668 Optimise HeadTracker's memory usage (#14130) BCFR-888 LP support chains that have not reached finality yet (#14366) support new heads polling over http rpc client (#14373) Bump CTF (#14518) TT-1550 Migrate remaining E2E workflows to the reusable workflow (#14403) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a 1-line bug fix for the LogPoller pruner that went into a larger commit on develop:
e514727
And a corresponding hotfix for the 2.16.0 release:
#14462
This PR was going to be that change, but since it already went into develop this just adds a regression test for it. Regression test is also a part of the hotfix.
See: BCFR-906
This updates the setup for the orm test for the pruner to include inserting logs for a second chain, and verifies that they don't get removed by the pruning query. Also adds a test for the paged version of the query, and enables parallelism.