-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BCFR-1048] - Logic to solve ocassional nonce gap issues #14984
Merged
prashantkumar1982
merged 9 commits into
develop
from
bcfr-1048-refactor-nonce-gap-handling-logic
Nov 4, 2024
Merged
[BCFR-1048] - Logic to solve ocassional nonce gap issues #14984
prashantkumar1982
merged 9 commits into
develop
from
bcfr-1048-refactor-nonce-gap-handling-logic
Nov 4, 2024
+70
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Farber98
commented
Oct 29, 2024
Quality Gate passedIssues Measures |
jmank88
requested changes
Oct 29, 2024
jmank88
reviewed
Nov 4, 2024
jmank88
reviewed
Nov 4, 2024
amit-momin
reviewed
Nov 4, 2024
jmank88
approved these changes
Nov 4, 2024
amit-momin
approved these changes
Nov 4, 2024
prashantkumar1982
approved these changes
Nov 4, 2024
prashantkumar1982
deleted the
bcfr-1048-refactor-nonce-gap-handling-logic
branch
November 4, 2024 22:17
cedric-cordenier
pushed a commit
that referenced
this pull request
Nov 5, 2024
* nonce gap handling * add changeset * refactor tests * add comment explaining situation * go sec no lint * fix flake * fix flakes * fix flake * use mock anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
getSequenceForAddr
function to use NonceAt instead of PendingNonceAt.Steps a NOP should follow to handle nonce gap issue:
NonceAutoSync
abandon all current transactions
checkboxResources
Merge together with: