Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCFR-963] - Remove Nonce Manual Override setting from UI #89

Merged
merged 7 commits into from
Nov 5, 2024
Merged

[BCFR-963] - Remove Nonce Manual Override setting from UI #89

merged 7 commits into from
Nov 5, 2024

Conversation

Farber98
Copy link
Collaborator

@Farber98 Farber98 commented Oct 2, 2024 •
edited
Loading

Description

The Next Nonce Manual Override setting is no longer connected to anything. It is safe to delete it from the UI since the backend does not process the setting anymore.

Resources:

Merge together with:

@Farber98 Farber98 force-pushed the bcfr-963-delete-nonce-manual-override-setting branch 2 times, most recently from 292c3b0 to c102b36 Compare October 2, 2024 14:19
@Farber98
remove nonce manual override from UI
bb14e8f 
Signed-off-by: Farber98 <juan.farber@smartcontract.com>
@Farber98
remove unused import
7a87741 
Signed-off-by: Farber98 <juan.farber@smartcontract.com>
@Farber98
add changeset
68d03c4 
Signed-off-by: Farber98 <juan.farber@smartcontract.com>
@Farber98 Farber98 force-pushed the bcfr-963-delete-nonce-manual-override-setting branch from c102b36 to 68d03c4 Compare October 2, 2024 14:43
@Farber98 Farber98 self-assigned this Oct 2, 2024
@Farber98 Farber98 mentioned this pull request Oct 28, 2024
Merged
@Farber98 Farber98 marked this pull request as ready for review October 29, 2024 18:10
chudilka1
chudilka1 reviewed Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@chudilka1 chudilka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cover changes with unit tests?

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)
11.11% Technical Debt Ratio on New Code (required ≤ 4%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@chudilka1 chudilka1 merged commit f0865ab into main Nov 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@chudilka1 chudilka1 chudilka1 approved these changes

@jmank88 jmank88 jmank88 approved these changes

Assignees

@Farber98 Farber98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Farber98 @jmank88 @chudilka1 @amit-momin