This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
bump package versions, fix lint #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilsonperkin
approved these changes
Sep 27, 2023
Co-authored-by: Ryan Wilson-Perkin <ryanwilsonperkin@gmail.com>
|
Looks like the new typescript eslint is using syntax that's unsupported by Node v14 that's running in CI. Need to drop support for that if we want to add it in. |
smeijer
pushed a commit
that referenced
this pull request
Oct 1, 2023
Node v14 is presenting some issues for #181 The new version of the `@typescript-eslint` library that `unimported` relies on makes use of features like the conditional assignment operator which wasn't added until Node v15. Given the LTS support schedule, it seems reasonable to drop the explicit support for Node v14 that's used in CI and update to v16 for support(still out of date, but less so) and v18 for testing (LTS support window).
|
Thank you! Much appreciated! FYI, this repo qualifies for hacktoberfest contributions if that's your thing. |
|
@all-contributors please add @MathiasVandePol for code |
|
I've put up a pull request to add @MathiasVandePol! 🎉 |
smeijer
pushed a commit
that referenced
this pull request
Oct 2, 2023
Adds @MathiasVandePol as a contributor for code. This was requested by smeijer [in this comment](#181 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 1.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.